From: Greg KH <greg@kroah.com>
To: Tejun Heo <tj@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org,
Seth Forshee <seth.forshee@canonical.com>,
Oleg Nesterov <oleg@redhat.com>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH pm 1/2] usb_storage: don't use set_freezable_with_signal()
Date: Mon, 14 Nov 2011 17:03:29 -0800 [thread overview]
Message-ID: <20111115010329.GA26429@kroah.com> (raw)
In-Reply-To: <20111101003726.GM18855@google.com>
On Mon, Oct 31, 2011 at 05:37:26PM -0700, Tejun Heo wrote:
> The current implementation of set_freezable_with_signal() is buggy and
> tricky to get right. usb-storage is the only user and its use can be
> avoided trivially.
>
> All usb-storage wants is to be able to sleep with timeout and get
> woken up if freezing() becomes true. This can be trivially
> implemented by doing interruptible wait w/ freezing() included in the
> wait condition. There's no reason to use set_freezable_with_signal().
>
> Perform interruptible wait on freezing() instead of using
> set_freezable_with_signal(), which is scheduled for removal.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
> Cc: Seth Forshee <seth.forshee@canonical.com>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> ---
>
> These two patches are on top of "freezer: fix various bugs and
> simplify implementation, take#2" patchset[1] and are also available in
> the following git branch.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git pm-kill-freezable_with_signal
>
> If usb-storage ppl are okay with it, I think routing this through pm
> would be the easiest. Oh, and this definitely is for the next merge
> window.
I'm fine with it going that way:
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
next prev parent reply other threads:[~2011-11-15 1:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 0:37 [PATCH pm 1/2] usb_storage: don't use set_freezable_with_signal() Tejun Heo
2011-11-01 0:37 ` [PATCH pm 2/2] freezer: kill unused set_freezable_with_signal() Tejun Heo
2011-11-01 16:40 ` [PATCH pm 1/2] usb_storage: don't use set_freezable_with_signal() Seth Forshee
2011-11-01 16:43 ` Tejun Heo
2011-11-08 23:06 ` Seth Forshee
2011-11-15 1:03 ` Greg KH [this message]
2011-11-15 20:34 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111115010329.GA26429@kroah.com \
--to=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=rjw@sisk.pl \
--cc=seth.forshee@canonical.com \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox