From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752953Ab1KOOyd (ORCPT ); Tue, 15 Nov 2011 09:54:33 -0500 Received: from mail-pz0-f42.google.com ([209.85.210.42]:48900 "EHLO mail-pz0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751120Ab1KOOyb (ORCPT ); Tue, 15 Nov 2011 09:54:31 -0500 Date: Tue, 15 Nov 2011 06:54:25 -0800 From: Tejun Heo To: Lin Ming Cc: Alan Stern , lkml , "linux-ide@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-pm@vger.kernel.org" , Jeff Garzik , "Rafael J. Wysocki" , James Bottomley , "Huang, Ying" , "Zhang, Rui" Subject: Re: [PATCH v2 4/4] ata: add ata port runtime PM callbacks Message-ID: <20111115145425.GL30922@google.com> References: <1321347089.26084.2.camel@minggr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1321347089.26084.2.camel@minggr> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 15, 2011 at 04:51:29PM +0800, Lin Ming wrote: > > This is not the right approach. You should look instead at > > scsi_dev_type_suspend() in scsi_pm.c. If the device is already runtime > > suspended then the routine should return immediately. > > How about below? > > diff --git a/drivers/scsi/scsi_pm.c b/drivers/scsi/scsi_pm.c > index d329f8b..94b60bd 100644 > --- a/drivers/scsi/scsi_pm.c > +++ b/drivers/scsi/scsi_pm.c > @@ -20,6 +20,9 @@ static int scsi_dev_type_suspend(struct device *dev, pm_message_t msg) > struct device_driver *drv; > int err; > > + if (pm_runtime_suspended(dev)) > + return 0; > + Something to be careful about is there are different types of suspend states (PMSG_*). IIUC, runtime PM is using PMSG_SUSPEND. Other states may or may not be compatible with PMSG_SUSPEND expectations, so you can skip suspend operation if the newly requested state is PMSG_SUSPEND but otherwise the controller needs to be woken up and told to comply to the new state. Thanks. -- tejun