From: Greg KH <greg@kroah.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: gregkh@suse.de, Nhan H Mai <nhan.h.mai@intel.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
alan@linux.intel.com
Subject: Re: [PATCH] serial/8250_pci: add a quirk for the kt serial controller
Date: Tue, 15 Nov 2011 11:18:37 -0800 [thread overview]
Message-ID: <20111115191837.GA27512@kroah.com> (raw)
In-Reply-To: <1319573794.9320.15.camel@dwillia2-mobl>
On Tue, Oct 25, 2011 at 01:16:34PM -0700, Dan Williams wrote:
> From: Dan Williams <dan.j.williams@intel.com>
> Date: Sun, 23 Oct 2011 15:06:24 -0700
> Subject: [PATCH v2] serial/8250_pci: add a quirk for the kt serial controller
>
> Workaround dropped notifications in the iir register. Prevent reads
> coincident with new interrupt notifications by reading the iir at most
> once per interrupt.
>
> Reported-by: Nhan H Mai <nhan.h.mai@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> Cc: stable <stable@vger.kernel.org>
> ---
> On Tue, 2011-10-25 at 04:28 +0200, Greg KH wrote:
> On Sun, Oct 23, 2011 at 03:27:16PM -0700, Dan Williams wrote:
> > > --- a/include/linux/pci_ids.h
> > > +++ b/include/linux/pci_ids.h
> [..]
> > Based on the comment at the top of this file, you shouldn't add this
> > entry to it.
> >
> > Care to redo the patch without that change?
>
> Ok, moved it to drivers/tty/serial/8250_pci.c and cleaned up the
> conflicting "/* This should be in linux/pci_ids.h */" comment.
This doesn't apply to the 3.2-rc1 kernel at all:
patching file drivers/tty/serial/8250.c
Hunk #1 FAILED at 1652.
1 out of 1 hunk FAILED -- saving rejects to file drivers/tty/serial/8250.c.rej
patching file drivers/tty/serial/8250_pci.c
Hunk #2 succeeded at 1118 with fuzz 1 (offset 9 lines).
Hunk #3 succeeded at 1143 (offset 9 lines).
Hunk #4 succeeded at 1228 (offset 9 lines).
patching file include/linux/serial_core.h
Hunk #1 FAILED at 350.
1 out of 1 hunk FAILED -- saving rejects to file include/linux/serial_core.h.rej
patching file drivers/tty/serial/8250.c
Hunk #1 FAILED at 1652.
1 out of 1 hunk FAILED -- saving rejects to file drivers/tty/serial/8250.c.rej
patching file drivers/tty/serial/8250_pci.c
Hunk #2 succeeded at 1118 with fuzz 1 (offset 9 lines).
Hunk #3 succeeded at 1143 (offset 9 lines).
Hunk #4 succeeded at 1228 (offset 9 lines).
patching file include/linux/serial_core.h
Hunk #1 FAILED at 350.
1 out of 1 hunk FAILED -- saving rejects to file include/linux/serial_core.h.rej
Care to fix it up and resend it?
thanks,
greg k-h
prev parent reply other threads:[~2011-11-15 19:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-23 22:27 [PATCH] serial/8250_pci: add a quirk for the kt serial controller Dan Williams
2011-10-25 2:28 ` Greg KH
2011-10-25 20:16 ` Dan Williams
2011-10-25 20:51 ` Greg KH
2011-10-25 22:52 ` Williams, Dan J
2011-11-03 16:34 ` Williams, Dan J
2011-11-15 19:18 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111115191837.GA27512@kroah.com \
--to=greg@kroah.com \
--cc=alan@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nhan.h.mai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox