From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932222Ab1KOUFn (ORCPT ); Tue, 15 Nov 2011 15:05:43 -0500 Received: from zone0.gcu-squad.org ([212.85.147.21]:41154 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932142Ab1KOUFl (ORCPT ); Tue, 15 Nov 2011 15:05:41 -0500 Date: Tue, 15 Nov 2011 21:05:28 +0100 From: Jean Delvare To: guenter.roeck@ericsson.com Cc: Tabi Timur-B04825 , Ben Dooks , Grant Likely , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Yuantian-B29983 Subject: Re: [PATCH] i2c/busses: (mpc) Add support for SMBUS_READ_BLOCK_DATA Message-ID: <20111115210528.0f9a0948@endymion.delvare> In-Reply-To: <1321384487.2309.363.camel@groeck-laptop> References: <1321338462-6138-1-git-send-email-guenter.roeck@ericsson.com> <20111115095445.3d34e99e@endymion.delvare> <1321384487.2309.363.camel@groeck-laptop> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.20.1; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Nov 2011 11:14:47 -0800, Guenter Roeck wrote: > On Tue, 2011-11-15 at 14:02 -0500, Tabi Timur-B04825 wrote: > > I think it's very important to keep the order as-is, if at all > > possible. This driver is very old and the hardware is used on all of > > our SOCs, dating back several years. It would be a nightmare to test > > it all over again. > > I'll see if I can work around that. 1-byte block reads may be tricky, > though, but maybe I can get that working as well. IMHO it's OK if 1-byte blocks are not supported. In practice the length of blocks seems to be known in advance and it's never 1. We can revisit if this is ever needed in practice for this specific bus driver. -- Jean Delvare