Re: [RFC PATCH] debugfs: add tools to printk 32-bit registers

Greg KH
2011-11-15T22:12:12Z

On Tue, Nov 15, 2011 at 10:37:34PM +0100, Alessandro Rubini wrote:
> Hi Greg. Thanks for looking.
>
> >> +/*
> >> + * The regset32 stuff is used to print 32-bit registers using the
> >> + * seq_file utilities. We offer printing a register set in an already-opened
> >> + * sequential file or create a debugfs file that only prints a regset32.
> >> + */
> >
> > Can this be part of the kerneldoc below somehow so that people are more
> > aware of it?
>
> Ok. There's also a file by Jon in Documentation that needs updating, as it
> has all the other debugfs file types.

Ah, yes, that would be good.

> > +int debugfs_print_regs32(struct seq_file *s, struct debugfs_reg32 *regs,
> >> + int nregs, void __iomem *base, char *prefix)
>
> > This function also needs to be part of debugfs.h in the "debugfs is not
> > enabled" section of the file, right?
>
> Not really. The other one makes a regiters-only file, and it's good
> to register it withouth ifdef.
>
> This one is used to embed a register block in a file with more
> stuff, so it shouldn't be used if debugfs is not selected (btw,
> I compiled my internal stuff with and without CONFIG_DEBUG_FS
> before rebasing to next).

That makes sense, thanks.

> So, I'll post a V2 shortly, unless you refuse it in reply to this.

Nope, a v2 would be great, thanks.

greg k-h