From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757707Ab1KPB0u (ORCPT ); Tue, 15 Nov 2011 20:26:50 -0500 Received: from fieldses.org ([174.143.236.118]:59432 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757688Ab1KPB0t (ORCPT ); Tue, 15 Nov 2011 20:26:49 -0500 Date: Tue, 15 Nov 2011 20:26:48 -0500 From: "J. Bruce Fields" To: Stephen Rothwell Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: build failure after merge of the nfsd tree Message-ID: <20111116012648.GE12453@fieldses.org> References: <20111116102952.d653d19f69ca5a7fad8a0291@canb.auug.org.au> <20111116001404.GD12453@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111116001404.GD12453@fieldses.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 15, 2011 at 07:14:04PM -0500, J. Bruce Fields wrote: > On Wed, Nov 16, 2011 at 10:29:52AM +1100, Stephen Rothwell wrote: > > Hi Bruce, > > > > After merging the nfsd tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > fs/nfsd/nfs4state.c:4446:5: error: expected ';', ',' or ')' before 'void' > > fs/nfsd/nfs4state.c: In function 'nfsd_forget_locks': > > fs/nfsd/nfs4state.c:4468:2: error: implicit declaration of function 'nfsd_release_n_owners' [-Werror=implicit-function-declaration] > > > > Caused by commit 16bfdaafa2c6 ("nfsd4: share open and lock owner hash > > tables"). Please build test *before* releasing code ... :-( > > I do--so what happened? > > Aie, sorry, I see: we added a CONFIG_NFSD_FAULT_INJECTION recently, but > I didn't add that to my configs.... > > OK, I've fixed up my test scripts, and I'll push out a fix soon. Done, thanks for the report. --b.