From: Felipe Balbi <balbi@ti.com>
To: Valdis.Kletnieks@vt.edu
Cc: Felipe Balbi <balbi@ti.com>, Tony Lindgren <tony@atomide.com>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH/RESEND #3 5/7] arm: omap: smartreflex: clean ups all over
Date: Wed, 16 Nov 2011 12:09:53 +0200 [thread overview]
Message-ID: <20111116100950.GA27980@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <22157.1321403991@turing-police.cc.vt.edu>
[-- Attachment #1: Type: text/plain, Size: 679 bytes --]
On Tue, Nov 15, 2011 at 07:39:51PM -0500, Valdis.Kletnieks@vt.edu wrote:
> On Tue, 15 Nov 2011 10:46:03 +0200, Felipe Balbi said:
>
> > - int srid;
> > - int ip_type;
> > + struct list_head node;
> > + struct platform_device *pdev;
> > + struct omap_sr_nvalue_table *nvalue_table;
> > + struct voltagedomain *voltdm;
>
> As long as you're de-tabifying the function names that caused the problem...
>
> > int nvalue_count;
> > - bool autocomp_active;
> > - bool is_suspended;
>
> Why are you leaveing the rest of the struct tabified out to East Podunk?
de-tabifying ? I tabified the entire thing... Everything is aligned.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-16 10:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 8:45 [PATCH/RESEND #3 0/7] SmartReflex Patches Felipe Balbi
2011-11-15 8:45 ` [PATCH/RESEND #3 1/7] OMAP3+: PM: SR: add suspend/resume handlers Felipe Balbi
[not found] ` <87vcqj62gd.fsf@ti.com>
2011-11-19 0:35 ` Menon, Nishanth
2011-11-23 20:01 ` Kevin Hilman
2011-11-15 8:46 ` [PATCH/RESEND #3 2/7] arm: omap: smartreflex: add missing platform_set_drvdata() Felipe Balbi
2011-11-15 8:46 ` [PATCH/RESEND #3 3/7] arm: omap: smartreflex: use dev_get_drvdata() Felipe Balbi
2011-11-15 8:46 ` [PATCH/RESEND #3 4/7] arm: omap: smartreflex: move late_initcall() closer to its argument Felipe Balbi
2011-11-15 8:46 ` [PATCH/RESEND #3 5/7] arm: omap: smartreflex: clean ups all over Felipe Balbi
2011-11-16 0:39 ` Valdis.Kletnieks
2011-11-16 10:09 ` Felipe Balbi [this message]
2011-11-15 8:46 ` [PATCH/RESEND #3 6/7] arm: omap: smartreflex: fix IRQ handling bug Felipe Balbi
2011-11-17 0:06 ` Kevin Hilman
2011-11-17 7:08 ` Felipe Balbi
2011-11-15 8:46 ` [PATCH/RESEND #3 7/7] arm: omap: smartreflex: micro-optimization for sanity check Felipe Balbi
2011-11-17 0:09 ` [PATCH/RESEND #3 0/7] SmartReflex Patches Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111116100950.GA27980@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).