From: Ralf Baechle <ralf@linux-mips.org>
To: Victor Kamensky <kamensky@cisco.com>
Cc: David Daney <david.daney@cavium.com>,
"manesoni@cisco.com" <manesoni@cisco.com>,
"ananth@in.ibm.com" <ananth@in.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
Subject: Re: [PATCH 2/4] MIPS Kprobes: Deny probes on ll/sc instructions
Date: Wed, 16 Nov 2011 12:12:07 +0000 [thread overview]
Message-ID: <20111116121207.GA5079@linux-mips.org> (raw)
In-Reply-To: <Pine.GSO.4.58.1111081504560.10959@infra-view9.cisco.com>
On Tue, Nov 08, 2011 at 03:26:42PM -0800, Victor Kamensky wrote:
> > s/insturctions/instructions/
> >
> > Not only is it a bad idea, it will probably make them fail 100% of the time.
> >
> > It is also an equally bad idea to place a probe between any LL and SC
> > instructions. How do you prevent that?
>
> As per below code comment we don't prevent that. There is no way to do
> that.
Similar to the way that the addresses of loads and stores from userspace
are recorded in a special section we could build a list of forbidden
address range.
Is it worth it?
Ralf
next prev parent reply other threads:[~2011-11-16 12:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 17:03 [PATCH 0/4] MIPS Kprobes Maneesh Soni
2011-11-08 17:04 ` [PATCH 1/4] MIPS Kprobes: Fix OOPS in arch_prepare_kprobe() Maneesh Soni
2011-11-08 19:57 ` David Daney
2011-11-09 5:26 ` Maneesh Soni
2011-11-17 23:17 ` Ralf Baechle
2011-11-08 17:05 ` [PATCH 2/4] MIPS Kprobes: Deny probes on ll/sc instructions Maneesh Soni
2011-11-08 20:01 ` David Daney
2011-11-08 23:26 ` Victor Kamensky
2011-11-16 12:12 ` Ralf Baechle [this message]
2011-11-16 17:39 ` Victor Kamensky
2011-11-17 23:18 ` Ralf Baechle
2011-11-08 17:07 ` [PATCH 3/4] MIPS Kprobes: Refactoring Branch emulation Maneesh Soni
2011-11-17 23:18 ` Ralf Baechle
2011-11-08 17:08 ` [PATCH 4/4] MIPS Kprobes: Support branch instructions probing - v2 Maneesh Soni
2011-11-17 23:18 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111116121207.GA5079@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=ananth@in.ibm.com \
--cc=david.daney@cavium.com \
--cc=kamensky@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=manesoni@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).