From: Dan Carpenter <dan.carpenter@oracle.com>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: Richard Purdie <rpurdie@rpsys.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] leds: leds-lp3944, fix "sparse" warning "mixing different enum types"
Date: Wed, 16 Nov 2011 21:43:03 +0300 [thread overview]
Message-ID: <20111116184303.GC4349@mwanda> (raw)
In-Reply-To: <20111116160007.5a834380ca396153931cc238@studenti.unina.it>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
On Wed, Nov 16, 2011 at 04:00:07PM +0100, Antonio Ospite wrote:
> On Thu, 6 Oct 2011 23:34:44 +0200
> Antonio Ospite <ospite@studenti.unina.it> wrote:
>
> > Fix a warning from "sparse":
> >
> > drivers/leds/leds-lp3944.c:292:23: warning: mixing different enum types
> > drivers/leds/leds-lp3944.c:292:23: int enum led_brightness versus
> > drivers/leds/leds-lp3944.c:292:23: int enum lp3944_status
> >
> > Keeping track of LP3944_LED_STATUS_OFF and LP3944_LED_STATUS_ON only in
> > lp3944_led_set_brightness() is OK, as the handling of DIM (blinking)
> > mode[s] is in lp3944_led_set_blink().
> >
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
>
> Ping.
> Dan, did you receive this one? I can't see it in 3.2-rc2.
Richard is the maintainer, not me. But he's on the CC list as well
so hopefully he can answer your question.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2011-11-16 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 9:32 [sparse stuff] bug in lp3944_led_set_brightness() Dan Carpenter
2011-10-05 20:21 ` Antonio Ospite
2011-10-06 21:34 ` [PATCH] leds: leds-lp3944, fix "sparse" warning "mixing different enum types" Antonio Ospite
2011-11-16 15:00 ` Antonio Ospite
2011-11-16 18:43 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111116184303.GC4349@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ospite@studenti.unina.it \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox