From: Ralf Baechle <ralf@linux-mips.org>
To: Rene Bolldorf <xsecute@googlemail.com>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Initial PCI support for Atheros 724x SoCs. (v2)
Date: Thu, 17 Nov 2011 14:33:32 +0000 [thread overview]
Message-ID: <20111117143331.GE20183@linux-mips.org> (raw)
In-Reply-To: <1321538577-548-2-git-send-email-xsecute@googlemail.com>
On Thu, Nov 17, 2011 at 03:02:56PM +0100, Rene Bolldorf wrote:
Queued for 3.3 but:
> Subject: [PATCH 1/2] Initial PCI support for Atheros 724x SoCs. (v2)
Please don't put the (v2) at the end of the subject line but rather into
the initial part with the square brackets like:
Subject: [PATCH 1/2, v2] Initial PCI support for Atheros 724x SoCs.
That's so software like git-am will automatically discard that when
applying a patch.
Your use of non-ASCII characters is not quite yet supported in patchwork,
see:
http://patchwork.linux-mips.org/patch/3019/
http://patchwork.linux-mips.org/patch/3020/
My surname's spelling is also suffering from ASCII brain damaged software ...
> + switch (size) {
> + case 1:
> + addr = where & ~3;
> + mask = 0xff000000 >> ((where % 4) * 8);
> + tval = reg_read(ATH724X_PCI_DEV_BASE + addr);
> + tval = tval & ~mask;
> + *value = (tval >> ((4 - (where % 4))*8));
> + break;
> + case 2:
That's a very odd style of formatting. The Linux coding style (see
Documentation/) wants the break keyword indented with the same number
of tabs as the preceeding block.
Anyway, I took care of that.
Thanks,
Ralf
next prev parent reply other threads:[~2011-11-17 14:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 10:55 [PATCH 0/2] Summary Rene Bolldorf
2011-11-16 10:55 ` [PATCH 1/2] Initial PCI support for Atheros 724x SoCs Rene Bolldorf
2011-11-16 19:50 ` Manuel Lauss
2011-11-16 10:55 ` [PATCH 2/2] Initial support for the Ubiquiti Networks XM board Rene Bolldorf
2011-11-16 20:02 ` Gabor Juhos
[not found] ` <CAEWqx58YQAKQ=D=qteipHQq5Q==+aEiKMYP4FczMZ9kReogMDQ@mail.gmail.com>
2011-11-17 10:31 ` René Bolldorf
2011-11-17 14:02 ` [PATCH 0/2] Summary Rene Bolldorf
2011-11-17 14:02 ` [PATCH 1/2] Initial PCI support for Atheros 724x SoCs. (v2) Rene Bolldorf
2011-11-17 14:33 ` Ralf Baechle [this message]
2011-11-17 14:02 ` [PATCH 2/2] Initial support for the Ubiquiti Networks XM board (rev 1.0). (patch v2) Rene Bolldorf
2011-11-17 14:34 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111117143331.GE20183@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=xsecute@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).