From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: David Ahern <dsahern@gmail.com>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org,
peterz@infradead.org, fweisbec@gmail.com
Subject: Re: [PATCH v2] perf tools: make -C consistent across commands (for cpu list arg)
Date: Thu, 17 Nov 2011 22:41:39 -0200 [thread overview]
Message-ID: <20111118004139.GA2315@ghostprotocols.net> (raw)
In-Reply-To: <4EC59460.7020705@gmail.com>
Em Thu, Nov 17, 2011 at 04:10:24PM -0700, David Ahern escreveu:
> On 11/13/2011 11:30 AM, David Ahern wrote:
> > Currently the meaning of -C varies by perf command: for perf-top,
> > perf-stat, perf-record it means cpu list. For perf-report it
> > means comm list. Then perf-annotate, perf-report and perf-script
> > use -c for cpu list.
> >
> > Fix annotate, report and script to use -C for cpu list to be
> > consistent with top, stat and record. This means report needs
> > to use -c for comm list which does introduce a backward
> > compatibility change.
>
> Any objections to making this argument consistent? I am waiting to send
> a follow-on patch that adds comm filtering to perf-script.
Its OK for perf/core, I'll apply and try to publish what I have
tomorrow.
- Arnaldo
next prev parent reply other threads:[~2011-11-18 0:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-13 18:30 [PATCH v2] perf tools: make -C consistent across commands (for cpu list arg) David Ahern
2011-11-17 23:10 ` David Ahern
2011-11-18 0:41 ` Arnaldo Carvalho de Melo [this message]
2011-12-05 13:00 ` [tip:perf/core] " tip-bot for David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111118004139.GA2315@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).