From: Thomas Jarosch <thomas.jarosch@intra2net.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix comparison using wrong pointer variable in dma debug code
Date: Fri, 18 Nov 2011 17:47:20 +0100 [thread overview]
Message-ID: <201111181747.20894.thomas.jarosch@intra2net.com> (raw)
In-Reply-To: <20111117200136.GC26847@hmsreliant.think-freely.org>
On Thursday, 17. November 2011 21:01:36 Neil Horman wrote:
> Thanks for the catch! Viro just pointed out you can also remove the ?
> true/false changes and extraneous parens, reducing it to:
>
> (a->dev_addr == b->dev_addr) && (a->dev == b->dev)
> But its not strictly necessecary
>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
I'd say just commit the fix, that rarely used function
is not worth the extra effort.
Cheers,
Thomas
next prev parent reply other threads:[~2011-11-18 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 19:31 [PATCH] Fix comparison using wrong pointer variable in dma debug code Thomas Jarosch
2011-11-17 20:01 ` Neil Horman
2011-11-18 16:47 ` Thomas Jarosch [this message]
2011-11-17 20:03 ` Joe Perches
2011-11-21 10:37 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111181747.20894.thomas.jarosch@intra2net.com \
--to=thomas.jarosch@intra2net.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox