From: Serge Hallyn <serge.hallyn@canonical.com>
To: Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>
Cc: richard@nod.at, containers@lists.linux-foundation.org,
oleg@redhat.com, eparis@redhat.com, linux-kernel@vger.kernel.org,
dhowells@redhat.com
Subject: [PATCH 1/1] __send_signal: pass q->info, not info, to userns_fixup_signal_uid (v2)
Date: Fri, 18 Nov 2011 18:41:48 -0600 [thread overview]
Message-ID: <20111119004148.GA16259@sergelap> (raw)
Eric Biederman pointed out that passing info is a bug and could lead
to a NULL pointer deref to boot.
A collection of signal, securebits, filecaps, cap_bounds, and a few other ltp
tests passed with this kernel.
Changelog:
Nov 18: previous patch missed a leading '&'
Signed-off-by: Serge Hallyn <serge.hallyn@canonical.com>
---
kernel/signal.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/signal.c b/kernel/signal.c
index c0f0782..170586b 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1118,7 +1118,7 @@ static int __send_signal(int sig, struct siginfo *info, struct task_struct *t,
break;
}
- userns_fixup_signal_uid(info, t);
+ userns_fixup_signal_uid(&q->info, t);
} else if (!is_si_special(info)) {
if (sig >= SIGRTMIN && info->si_code != SI_USER) {
--
1.7.5.4
next reply other threads:[~2011-11-19 0:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-19 0:41 Serge Hallyn [this message]
2011-11-19 16:06 ` [PATCH 1/1] __send_signal: pass q->info, not info, to userns_fixup_signal_uid (v2) Jiri Slaby
2011-11-22 0:45 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111119004148.GA16259@sergelap \
--to=serge.hallyn@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox