From: Vasiliy Kulikov <segoon@openwall.com>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCH 3/3] security: Yama: add ptrace relationship tracking interface
Date: Sat, 19 Nov 2011 20:30:58 +0400 [thread overview]
Message-ID: <20111119163058.GA3131@albatros> (raw)
In-Reply-To: <1319672956-17114-4-git-send-email-keescook@chromium.org>
Hi Kees,
Thank you for working on this! We'll use Yama in Openwall too :-)
On Wed, Oct 26, 2011 at 16:49 -0700, Kees Cook wrote:
> + if (mode == PTRACE_MODE_ATTACH &&
> + ptrace_scope &&
> + !capable(CAP_SYS_PTRACE) &&
> + !task_is_descendant(current, child) &&
> + !ptracer_exception_found(current, child))
> + rc = -EPERM;
capable() is better to put after all other tests as a failed capable()
might emit a false positive warning into logs or something.
Thanks,
--
Vasiliy
next prev parent reply other threads:[~2011-11-19 16:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 23:49 [PATCH v6 0/3] security: Yama LSM Kees Cook
2011-10-26 23:49 ` [PATCH 1/3] " Kees Cook
2011-10-26 23:49 ` [PATCH 2/3] security: create task_free security callback Kees Cook
2011-10-26 23:49 ` [PATCH 3/3] security: Yama: add ptrace relationship tracking interface Kees Cook
2011-11-19 16:30 ` Vasiliy Kulikov [this message]
2011-11-19 16:59 ` Solar Designer
2011-11-21 18:40 ` Kees Cook
2011-11-01 20:45 ` [PATCH v6 0/3] security: Yama LSM James Morris
2011-11-01 21:05 ` Kees Cook
2011-11-01 21:37 ` James Morris
2011-11-01 23:23 ` Kees Cook
2011-11-18 4:17 ` James Morris
2011-11-18 21:39 ` Kees Cook
2011-11-18 21:45 ` Roland McGrath
2011-11-18 22:44 ` Kees Cook
2011-11-18 23:18 ` Kees Cook
2011-11-21 19:18 ` [RFC] Make Yama pid_ns aware Vasiliy Kulikov
2011-11-21 19:42 ` Kees Cook
2011-11-22 18:13 ` Serge Hallyn
2011-11-22 19:20 ` Vasiliy Kulikov
2011-11-22 20:10 ` Serge Hallyn
2011-11-23 7:45 ` Vasiliy Kulikov
2011-11-23 14:41 ` Serge Hallyn
2011-11-23 14:49 ` Serge E. Hallyn
2011-11-23 16:55 ` Vasiliy Kulikov
2011-11-23 17:00 ` Serge Hallyn
2011-11-28 18:12 ` Kees Cook
2011-11-28 18:14 ` Vasiliy Kulikov
2011-11-28 19:16 ` [RFC -resend] " Vasiliy Kulikov
2011-11-28 19:35 ` Kees Cook
2011-11-28 20:15 ` Kees Cook
2011-11-28 20:00 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111119163058.GA3131@albatros \
--to=segoon@openwall.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox