From: Wu Fengguang <fengguang.wu@intel.com>
To: <linux-fsdevel@vger.kernel.org>
Cc: Jan Kara <jack@suse.cz>, Wu Fengguang <fengguang.wu@intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/5] writeback: balanced_rate cannot exceed write bandwidth
Date: Mon, 21 Nov 2011 21:03:43 +0800 [thread overview]
Message-ID: <20111121131215.645601798@intel.com> (raw)
In-Reply-To: 20111121130342.211953629@intel.com
[-- Attachment #1: ref-bw-up-bound --]
[-- Type: text/plain, Size: 970 bytes --]
Add an upper limit to balanced_rate according to the below inequality.
This filters out some rare but huge singular points, which at least
enables more readable gnuplot figures.
When there are N dd dirtiers,
balanced_dirty_ratelimit = write_bw / N
So it holds that
balanced_dirty_ratelimit <= write_bw
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
mm/page-writeback.c | 5 +++++
1 file changed, 5 insertions(+)
--- linux-next.orig/mm/page-writeback.c 2011-11-17 20:18:03.000000000 +0800
+++ linux-next/mm/page-writeback.c 2011-11-17 20:18:23.000000000 +0800
@@ -804,6 +804,11 @@ static void bdi_update_dirty_ratelimit(s
*/
balanced_dirty_ratelimit = div_u64((u64)task_ratelimit * write_bw,
dirty_rate | 1);
+ /*
+ * balanced_dirty_ratelimit ~= (write_bw / N) <= write_bw
+ */
+ if (unlikely(balanced_dirty_ratelimit > write_bw))
+ balanced_dirty_ratelimit = write_bw;
/*
* We could safely do this and return immediately:
next prev parent reply other threads:[~2011-11-21 13:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 13:03 [PATCH 0/5] dirty throttling bits for 3.3 Wu Fengguang
2011-11-21 13:03 ` Wu Fengguang [this message]
2011-11-21 22:50 ` [PATCH 1/5] writeback: balanced_rate cannot exceed write bandwidth Jan Kara
2011-11-22 6:41 ` Wu Fengguang
2011-11-22 21:04 ` Jan Kara
2011-11-23 13:17 ` Wu Fengguang
2011-11-21 13:03 ` [PATCH 2/5] writeback: charge leaked page dirties to active tasks Wu Fengguang
2011-11-21 21:49 ` Andrew Morton
2011-11-21 23:46 ` Jan Kara
2011-11-22 13:35 ` Wu Fengguang
2011-11-21 13:03 ` [PATCH 3/5] writeback: fix dirtied pages accounting on sub-page writes Wu Fengguang
2011-11-22 0:11 ` Jan Kara
2011-11-22 9:21 ` Wu Fengguang
2011-11-22 12:21 ` Jan Kara
2011-11-22 12:30 ` Wu Fengguang
2011-11-22 12:48 ` Jan Kara
2011-11-22 13:02 ` Wu Fengguang
2011-11-22 12:57 ` Peter Zijlstra
2011-11-22 13:07 ` Wu Fengguang
2011-11-22 13:41 ` Wu Fengguang
2011-11-22 13:53 ` Peter Zijlstra
2011-11-22 14:11 ` Wu Fengguang
2011-11-28 13:51 ` Wu Fengguang
2011-11-21 13:03 ` [PATCH 4/5] writeback: fix dirtied pages accounting on redirty Wu Fengguang
2011-11-21 21:51 ` Andrew Morton
2011-11-22 13:59 ` Wu Fengguang
2011-11-21 13:03 ` [PATCH 5/5] writeback: dirty ratelimit - think time compensation Wu Fengguang
2011-11-23 12:44 ` [PATCH 0/5] dirty throttling bits for 3.3 Peter Zijlstra
2011-11-28 13:56 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111121131215.645601798@intel.com \
--to=fengguang.wu@intel.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox