Re: [PATCH] Fixed use of rounddown_pow_of_two in ramoops

[Andrew Morton <akpm@linux-foundation.org>]

On Sat, 19 Nov 2011 14:32:15 +0100
Marco Stornelli <marco.stornelli@gmail.com> wrote:

> From: Marco Stornelli <marco.stornelli@gmail.com>
> 
> The return value of rounddown_pow_of_two wasn't evaluated, so the
> operation was a no-op.
> 
> Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
> ---
>  drivers/char/ramoops.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/ramoops.c b/drivers/char/ramoops.c
> index 7c7f42a1f8..9658116 100644
> --- a/drivers/char/ramoops.c
> +++ b/drivers/char/ramoops.c
> @@ -126,8 +126,8 @@ static int __init ramoops_probe(struct platform_device *pdev)
>                 goto fail3;
>         }
> 
> -       rounddown_pow_of_two(pdata->mem_size);
> -       rounddown_pow_of_two(pdata->record_size);
> +       pdata->mem_size = rounddown_pow_of_two(pdata->mem_size);
> +       pdata->record_size = rounddown_pow_of_two(pdata->record_size);
> 
>         /* Check for the minimum memory size */
>         if (pdata->mem_size < MIN_MEM_SIZE &&

waah.

Reported-by: Andrew Morton <akpm@linux-foundation.org>

There goes my chance to get my name in the kernel tree :(