From: Andrew Morton <akpm@linux-foundation.org>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtc-cmos: fix broken NVRAM bank 2 writing
Date: Tue, 22 Nov 2011 15:16:05 -0800 [thread overview]
Message-ID: <20111122151605.827702bf.akpm@linux-foundation.org> (raw)
In-Reply-To: <201111132320.34420.linux@rainbow-software.org>
On Sun, 13 Nov 2011 23:20:31 +0100
Ondrej Zary <linux@rainbow-software.org> wrote:
> Fix writing to NVRAM bank 2 in rtc-cmos driver. It never worked since its
> introduction in 2.6.28 because of a typo.
>
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
>
> --- linux-3.1-orig/drivers/rtc/rtc-cmos.c 2011-10-24 09:10:05.000000000 +0200
> +++ linux-3.1/drivers/rtc/rtc-cmos.c 2011-11-08 17:43:29.000000000 +0100
> @@ -164,7 +164,7 @@ static inline unsigned char cmos_read_ba
> static inline void cmos_write_bank2(unsigned char val, unsigned char addr)
> {
> outb(addr, RTC_PORT(2));
> - outb(val, RTC_PORT(2));
> + outb(val, RTC_PORT(3));
> }
>
> #else
Strange. Can you suggest why this bug has lived for so long without anyone
noticing it?
next prev parent reply other threads:[~2011-11-22 23:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-13 22:20 [PATCH] rtc-cmos: fix broken NVRAM bank 2 writing Ondrej Zary
2011-11-22 23:16 ` Andrew Morton [this message]
2011-11-23 7:29 ` Ondrej Zary
-- strict thread matches above, loose matches on Subject: below --
2011-11-08 17:07 Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122151605.827702bf.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox