From: Tejun Heo <tj@kernel.org>
To: Dave Young <dyoung@redhat.com>
Cc: WANG Cong <xiyou.wangcong@gmail.com>,
kexec@lists.infradead.org, tim@edgecast.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] percpu: fix chunk range calculation
Date: Tue, 22 Nov 2011 08:02:08 -0800 [thread overview]
Message-ID: <20111122160208.GA3250@google.com> (raw)
In-Reply-To: <4ECB104C.3040801@redhat.com>
Hello, Dave.
On Tue, Nov 22, 2011 at 11:00:28AM +0800, Dave Young wrote:
> > Maybe we can add comment there how it can be further simplified and
> > why things look more complicated than necessary?
>
> I wonder if it's good to add something like CONFIG_PER_CPU_DEBUG?
Yeah, having more comprehensive sanity checks w/ CONFIG_PER_CPU_DEBUG
would be really nice.
> Anyway I have no strong opinion with this. I'm fine to either of adding
> comment and put it into debug around.
I mostly just don't want to lose the minimal but useful checks in the
phys conversion function. Please feel free to improve it.
Thank you.
--
tejun
next prev parent reply other threads:[~2011-11-22 16:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1318376345.2050.20.camel@boudreau>
[not found] ` <j9r5m5$b18$1@dough.gmane.org>
[not found] ` <1321296650.2066.17.camel@boudreau>
2011-11-15 8:14 ` Crash during vmcore_init Dave Young
2011-11-15 13:47 ` Américo Wang
2011-11-15 13:50 ` Américo Wang
2011-11-15 22:32 ` Tim Hartrick
2011-11-16 2:22 ` Dave Young
2011-11-16 18:20 ` Tim Hartrick
2011-11-17 3:30 ` Dave Young
2011-11-17 4:34 ` Tejun Heo
2011-11-17 4:46 ` Dave Young
[not found] ` <CAMMEr5k_ynqg5-7Looar2DxXTGZcMqi5Lo+jtETn9awO_bsaGg@mail.gmail.com>
2011-11-17 7:21 ` Dave Young
2011-11-17 7:23 ` Tejun Heo
2011-11-17 7:42 ` Américo Wang
2011-11-17 16:40 ` Tim Hartrick
2011-11-18 8:43 ` Dave Young
2011-11-18 8:45 ` Dave Young
2011-11-18 18:55 ` [PATCH] percpu: fix chunk range calculation Tejun Heo
2011-11-21 1:45 ` Dave Young
2011-11-21 17:01 ` Tejun Heo
2011-11-22 3:00 ` Dave Young
2011-11-22 16:02 ` Tejun Heo [this message]
[not found] ` <CAMMEr5my3pt0HXWd1EdwAeZKAJ8JP04tM_WqvHdCNvW=Q3ifvg@mail.gmail.com>
2011-11-22 2:52 ` Dave Young
2011-11-21 21:10 ` Tejun Heo
2011-11-22 2:48 ` Dave Young
2011-11-22 16:19 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122160208.GA3250@google.com \
--to=tj@kernel.org \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@edgecast.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).