From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [git pull] vfs fix
Date: Tue, 22 Nov 2011 21:09:30 +0000 [thread overview]
Message-ID: <20111122210930.GJ2203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFz+9TN2z+q9vH2g0wMq6_X8AfYANrntGQd_et+U5+c74Q@mail.gmail.com>
On Tue, Nov 22, 2011 at 09:48:36AM -0800, Linus Torvalds wrote:
> On Tue, Nov 22, 2011 at 9:44 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> > Really embarrassing braino; kudos to jlayton for catching that one.
> > Please, pull from
> > git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus
> >
> > Al Viro (1):
> > ? ? ?mount_subtree() pointless use-after-free
>
> Hmm. That's not at all what I get.
>
> Or rather, that's just *one* of the commits I get. I also get these two:
>
> microblaze: bury asm/namei.h
> iio: fix a leak due to improper use of anon_inode_getfd()
>
> which look like they may be valid, but for all I know you meant to
> leave them for the next merge window. So not pulled. Please check your
> tree,
Umm... OK, I see what happened - buggered script generating
shortlog/diffstat plus me not noticing that it hadn't reported a couple
of fixes I'd put there yesterday. All 3 are intended to be sent;
iio is an outright bugfix, microblaze one could wait, in theory, but
it's guaranteed to be safe (removal of header nothing includes, done on
all architectures years ago, with microblaze tree apparently copying it
from sparc and keeping all along) and the sooner such things are buried,
the fewer places will copy that *again*...
Anyway, consider that a pull request for all 3 commits. Proper shortlog
and diffstat follow.
Shortlog:
Al Viro (3):
microblaze: bury asm/namei.h
iio: fix a leak due to improper use of anon_inode_getfd()
mount_subtree() pointless use-after-free
Diffstat:
arch/microblaze/include/asm/namei.h | 22 ----------------------
drivers/staging/iio/industrialio-core.c | 10 +++++++++-
fs/namespace.c | 6 ++++--
3 files changed, 13 insertions(+), 25 deletions(-)
FWIW, the fixed form of script follows; if you see any potential problems in
it, please tell:
echo Shortlog:
base=`git merge-base origin "$1"`
git log --pretty=short "$base..$1" | git shortlog
echo Diffstat:
git diff --stat -M "$base..$1"
next prev parent reply other threads:[~2011-11-22 21:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 17:44 [git pull] vfs fix Al Viro
2011-11-22 17:48 ` Linus Torvalds
2011-11-22 21:09 ` Al Viro [this message]
2011-11-22 21:24 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2016-11-27 1:13 Al Viro
2016-11-27 1:48 ` Linus Torvalds
2016-11-27 2:25 ` Al Viro
2016-11-27 2:51 ` Al Viro
2016-11-27 3:04 ` Al Viro
2016-11-28 8:54 ` Yan, Zheng
2016-11-27 2:53 ` Linus Torvalds
2016-03-31 4:27 Al Viro
2015-05-31 21:37 Al Viro
2011-08-07 8:54 Al Viro
2011-02-24 7:20 Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122210930.GJ2203@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox