From: Mika Westerberg <mika.westerberg@iki.fi>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"vinod.koul@intel.com" <vinod.koul@intel.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"rmallon@gmail.com" <rmallon@gmail.com>,
Rafal Prylowski <prylowski@metasoft.pl>
Subject: Re: [PATCH 2/2] dma/ep93xx_dma: prevent ep93xx_dma_tasklet() to access empty list
Date: Wed, 23 Nov 2011 07:12:35 +0200 [thread overview]
Message-ID: <20111123051235.GA2705@mwesterb-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <ADE657CA350FB648AAC2C43247A983F001F3E96DA6B7@AUSP01VMBX24.collaborationhost.net>
On Tue, Nov 22, 2011 at 02:26:52PM -0600, H Hartley Sweeten wrote:
>
> I still don't like the BUG_ON here. Is it even possible to get here with
> an empty list now that your catching it in the tasklet?
It's there just to make sure that we don't corrupt any memory if the list is
empty because of some other, yet unknown, bug.
>
> But, ep93xx_dma_set_active() also has a BUG_ON test so...
>
> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Thanks.
next prev parent reply other threads:[~2011-11-23 5:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 19:45 [PATCH 1/2] dma/ep93xx_dma: fix initialization of M2M control register Mika Westerberg
2011-11-22 19:45 ` [PATCH 2/2] dma/ep93xx_dma: prevent ep93xx_dma_tasklet() to access empty list Mika Westerberg
2011-11-22 20:26 ` H Hartley Sweeten
2011-11-23 5:12 ` Mika Westerberg [this message]
2011-11-23 11:00 ` Vinod Koul
2011-11-24 5:47 ` Mika Westerberg
2011-11-22 20:16 ` [PATCH 1/2] dma/ep93xx_dma: fix initialization of M2M control register H Hartley Sweeten
2011-11-23 9:05 ` Rafal Prylowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111123051235.GA2705@mwesterb-mobl.ger.corp.intel.com \
--to=mika.westerberg@iki.fi \
--cc=dan.j.williams@intel.com \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prylowski@metasoft.pl \
--cc=rmallon@gmail.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox