Re: [PATCH] kconfig: Fix checking return value of 'fwrite'

Arnaud Lacombe
2011-10-07T03:29:55Z

Hi,

2011/10/6 Reinhard Tartler <Reinhard.Tartler@informatik.uni-erlangen.de>:
> fwrite indicates '1' written member if a zero-length string is written.
you forgot the "Signed-off-by: " part :)

- Arnaud

> ---
>  scripts/kconfig/lkc.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/kconfig/lkc.h b/scripts/kconfig/lkc.h
> index b633bdb..727d265 100644
> --- a/scripts/kconfig/lkc.h
> +++ b/scripts/kconfig/lkc.h
> @@ -90,7 +90,7 @@ struct conf_printer {
>  /* confdata.c and expr.c */
>  static inline void xfwrite(const void *str, size_t len, size_t count, FILE *out)
>  {
> -       if (fwrite(str, len, count, out) < count)
> +       if (len > 0 && fwrite(str, len, count, out) < count)
>                fprintf(stderr, "\nError in writing or end of file.\n");
>  }
>
> --
> 1.7.0.4
>
> --
> Reinhard Tartler                     Department of Computer Science IV
> Martensstr 1, 91058 Erlangen Germany, University of Erlangen-Nuremberg
>            http://www4.informatik.uni-erlangen.de/~tartler
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>