From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755913Ab1KXDQc (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Nov 2011 22:16:32 -0500
Received: from mail.windriver.com ([147.11.1.11]:46309 "EHLO
	mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755275Ab1KXDQb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Nov 2011 22:16:31 -0500
Date: Wed, 23 Nov 2011 22:16:19 -0500
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Axel Lin <axel.lin@gmail.com>
CC: <linux-kernel@vger.kernel.org>, Wan ZongShun <mcuos.com@gmail.com>,
        Grant Likely <grant.likely@secretlab.ca>,
        <spi-devel-general@lists.sourceforge.net>
Subject: Re: [PATCH] spi: nuc900: Include linux/module.h
Message-ID: <20111124031619.GC10880@windriver.com>
References: <1322104251.16201.8.camel@phoenix>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1322104251.16201.8.camel@phoenix>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[[PATCH] spi: nuc900: Include linux/module.h] On 24/11/2011 (Thu 11:10) Axel Lin wrote:

> Include linux/module.h to fix below build error:

Looks fine to me ; I'll assume that this is going upstream via the
nuc900 maintainer since the module split up is old news at this point
in time.

Thanks,
Paul.

> 
>   CC      drivers/spi/spi-nuc900.o
> drivers/spi/spi-nuc900.c:484: error: 'THIS_MODULE' undeclared here (not in a function)
> drivers/spi/spi-nuc900.c:489: error: expected declaration specifiers or '...' before string constant
> drivers/spi/spi-nuc900.c:489: warning: data definition has no type or storage class
> drivers/spi/spi-nuc900.c:489: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> drivers/spi/spi-nuc900.c:489: warning: function declaration isn't a prototype
> drivers/spi/spi-nuc900.c:490: error: expected declaration specifiers or '...' before string constant
> drivers/spi/spi-nuc900.c:490: warning: data definition has no type or storage class
> drivers/spi/spi-nuc900.c:490: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> drivers/spi/spi-nuc900.c:490: warning: function declaration isn't a prototype
> drivers/spi/spi-nuc900.c:491: error: expected declaration specifiers or '...' before string constant
> drivers/spi/spi-nuc900.c:491: warning: data definition has no type or storage class
> drivers/spi/spi-nuc900.c:491: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> drivers/spi/spi-nuc900.c:491: warning: function declaration isn't a prototype
> drivers/spi/spi-nuc900.c:492: error: expected declaration specifiers or '...' before string constant
> drivers/spi/spi-nuc900.c:492: warning: data definition has no type or storage class
> drivers/spi/spi-nuc900.c:492: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS'
> drivers/spi/spi-nuc900.c:492: warning: function declaration isn't a prototype
> make[2]: *** [drivers/spi/spi-nuc900.o] Error 1
> make[1]: *** [drivers/spi] Error 2
> make: *** [drivers] Error 2
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
>  drivers/spi/spi-nuc900.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/spi/spi-nuc900.c b/drivers/spi/spi-nuc900.c
> index 21c70b2..182e9c8 100644
> --- a/drivers/spi/spi-nuc900.c
> +++ b/drivers/spi/spi-nuc900.c
> @@ -8,6 +8,7 @@
>   *
>   */
>  
> +#include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/spinlock.h>
>  #include <linux/workqueue.h>
> -- 
> 1.7.5.4
> 
> 
>