public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
	Sangbeom Kim <sbkim73@samsung.com>, Liam Girdwood <lrg@ti.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: samsung: drop unknown Kconfig symbol
Date: Thu, 24 Nov 2011 22:22:12 +0000	[thread overview]
Message-ID: <20111124222212.GA21244@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1322164748.25125.88.camel@x61.thuisdomein>

On Thu, Nov 24, 2011 at 08:59:08PM +0100, Paul Bolle wrote:
> On Thu, 2011-11-24 at 19:19 +0000, Mark Brown wrote:

> > The cost of extra platforms is really
> > very low and people actually send me patches for the OpenMoko devices
> > from time to time (much more frequently than for most other boards) so
> > at least someone cares.

> But - repeating my message - none of those patches made the code in the
> mainline tree buildable.

Which is a problem because...  (and note that you mean "selectable in
Kconfig" here).

> I don't have any stake in the GTA01 code. So I don't really mind
> deferring this discussion to (say) the end of the v3.3 merge period.
> But, surely, there must be a point where one can conclude that
> unbuildable code is just that?

No.  Removing this code has negative value.  There is no meaningful cost
in having it in mainline; your patch has been the biggest piece of work
so far other than updates done by people actively working on the
machine.  On the other hand the OpenMoko guys from time to time send
useful patches and report interesting bugs (they sent a patch only last
week in fact) and are definitely a user for the code (which is more than
can be said for most of the legacy boards in mainline).

Please take a step back, think about what value would be brought by
making this change.

  reply	other threads:[~2011-11-24 22:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-24 17:17 [PATCH] ASoC: samsung: drop unknown Kconfig symbol Paul Bolle
2011-11-24 17:22 ` Mark Brown
2011-11-24 19:09   ` Paul Bolle
2011-11-24 19:19     ` Mark Brown
2011-11-24 19:59       ` Paul Bolle
2011-11-24 22:22         ` Mark Brown [this message]
2011-11-25  9:41           ` Paul Bolle
2011-11-25 12:56             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111124222212.GA21244@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=pebolle@tiscali.nl \
    --cc=sbkim73@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox