From: Al Viro <viro@ZenIV.linux.org.uk>
To: Arnd Hannemann <arnd@arndnet.de>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: fix compile error
Date: Fri, 25 Nov 2011 09:33:31 +0000 [thread overview]
Message-ID: <20111125093331.GP2203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1322169950-21630-1-git-send-email-arnd@arndnet.de>
On Thu, Nov 24, 2011 at 10:25:50PM +0100, Arnd Hannemann wrote:
> Commit b46413367961c2e8bd827e067a231be982aaeee2 introduced the following compile error:
>
> CC drivers/staging/iio/industrialio-core.o
> linux-2.6/drivers/staging/iio/industrialio-core.c: In function 'iio_event_getfd':
> linux-2.6/drivers/staging/iio/industrialio-core.c:262:32: error: 'ev_int' undeclared (first use in this function)
> linux-2.6/drivers/staging/iio/industrialio-core.c:262:32: note: each undeclared identifier is reported only once for each function it appears in
>
> This patch fixes that.
Arrgh... My fault, sorry. Might be worth using the same local variable
for setting the bit as well...
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
> diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c
> index 2656409..a5b4a1f 100644
> --- a/drivers/staging/iio/industrialio-core.c
> +++ b/drivers/staging/iio/industrialio-core.c
> @@ -243,6 +243,7 @@ static const struct file_operations iio_event_chrdev_fileops = {
> static int iio_event_getfd(struct iio_dev *indio_dev)
> {
> int fd;
> + struct iio_event_interface *ev_int = indio_dev->event_interface;
>
> if (indio_dev->event_interface == NULL)
> return -ENODEV;
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2011-11-25 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 21:25 [PATCH] staging: iio: fix compile error Arnd Hannemann
2011-11-25 7:28 ` Jonathan Cameron
2011-11-25 9:33 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111125093331.GP2203@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=arnd@arndnet.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox