Re: [RFC PATCH 3/7] drivers/zio: core files for the ZIO input/output

Greg KH
2011-11-27T10:24:36Z

On Sat, Nov 26, 2011 at 11:58:41PM +0100, Federico Vaga wrote:
> In data sabato 26 novembre 2011 12:03:41, Greg KH ha scritto:
> > On Sat, Nov 26, 2011 at 06:30:42PM +0100, Alessandro Rubini wrote:
> > > +static struct kobj_type zdktype = { /* For standard and extended
> > > attribute */ + .release = NULL,
> >
> > Sweet!
> >
> > As-per the in-kernel documentation, I now get to mock you for doing
> > this :)
> >
> > Please NEVER DO THIS, you are ignoring the messages that the kernel
> > sends you when you remove one of these devices, and causing a memory
> > leak.
>
> Honestly we never see any messages about this.

Really? Then you never removed that kobject from memory. Please go
read the kobject documentation for more details.

> > Not nice at all, yet another reason to use a 'struct device'.
>
> I don't think is a valid reason, because device_release implementation require
> us to implement a release method within device, or device_type or class; so we
> can use kobj_type as well.

True, but it tries to make things easier to not get wrong, like you are
here.

Please fix this.

greg k-h