From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751434Ab1K0JWz (ORCPT ); Sun, 27 Nov 2011 04:22:55 -0500 Received: from out2.smtp.messagingengine.com ([66.111.4.26]:53082 "EHLO out2.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750900Ab1K0JWx (ORCPT ); Sun, 27 Nov 2011 04:22:53 -0500 X-Sasl-enc: 4opBvNZQIUerS5XLmVMXqpwyB654G1d/aXZpNIcKqDQQ 1322385771 Date: Sat, 26 Nov 2011 16:43:25 -0800 From: Greg KH To: Jesper Juhl Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Paul Gortmaker , Michael Hennerich , Greg Kroah-Hartman , Jonathan Cameron Subject: Re: [PATCH] [staging] iio, adc: Do not leak memory in ad7280_event_handler() Message-ID: <20111127004325.GA21259@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 06, 2011 at 10:49:22PM +0100, Jesper Juhl wrote: > If ad7280_read_all_channels() returns <0 then we'll leak the memory > allocated to 'channels' when we return and that variable goes out of > scope. > This patch fixes the leak. This patch no longer applies to my tree, can you redo it against the next linux-next release and resend it? thanks, greg k-h