public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Ken O'Brien" <kernel@kenobrien.org>,
	lucas.demarchi@profusion.mobi, devel@driverdev.osuosl.org,
	gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: bcm: Adapter.h Checkpatch cleaning.
Date: Sat, 26 Nov 2011 17:13:01 -0800	[thread overview]
Message-ID: <20111127011301.GA2564@kroah.com> (raw)
In-Reply-To: <20111119071915.GJ29436@mwanda>

On Sat, Nov 19, 2011 at 10:19:15AM +0300, Dan Carpenter wrote:
> On Sat, Nov 19, 2011 at 02:19:54AM +0000, Ken O'Brien wrote:
> > Removed all checkpatch errors.
> > 
> > Checkpatch status before: total: 131 errors, 200 warnings, 648 lines checked
> > Checkpatch status after:  total: 0 errors, 194 warnings, 620 lines checked
> > 
> 
> I don't have strong opinions personally, but I think the prefered way
> is to do this for one class of errors at a time.  It makes the patch
> smaller and easier to review.  Then send the series of patches.

Yes, that is my prefered way as well.

thanks,

greg k-h

      reply	other threads:[~2011-11-27  9:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-19  2:19 [PATCH 2/2] Staging: bcm: Adapter.h Checkpatch cleaning Ken O'Brien
2011-11-19  7:19 ` Dan Carpenter
2011-11-27  1:13   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111127011301.GA2564@kroah.com \
    --to=greg@kroah.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=kernel@kenobrien.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucas.demarchi@profusion.mobi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox