Re: [PATCH] regulator: Avoid potential NULL dereference in reg_fixed_voltage_probe()

Mark Brown
2011-11-27T11:35:32Z

On Sun, Nov 27, 2011 at 10:13:50AM +0800, Axel Lin wrote:

> - if (pdev->dev.of_node)
> + if (pdev->dev.of_node) {
> config = of_get_fixed_voltage_config(&pdev->dev);
> + if (!config)
> + return -ENOMEM;
> + }

Looking at this I'm thinking it's better to just drop the check for
of_node entirely and just let of_get_fixed_voltage_config() fail to find
what it needs.