From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755352Ab1K0Tui (ORCPT ); Sun, 27 Nov 2011 14:50:38 -0500 Received: from zone0.gcu-squad.org ([212.85.147.21]:26158 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753253Ab1K0Tug (ORCPT ); Sun, 27 Nov 2011 14:50:36 -0500 Date: Sun, 27 Nov 2011 20:50:28 +0100 From: Jean Delvare To: Wolfram Sang Cc: Axel Lin , linux-kernel@vger.kernel.org, Ben Dooks , Jochen Friedrich , Peter Korsgaard , Guan Xuetao , Manuel Lauss , Barry Song <21cnbao@gmail.com>, Linus Walleij , Yong Zhang , Lucas De Marchi , Grant Likely , Samuel Ortiz , linux-i2c@vger.kernel.org Subject: Re: [PATCH] i2c: convert drivers/i2c/* to use module_platform_driver() Message-ID: <20111127205028.708ea59f@endymion.delvare> In-Reply-To: <20111127194648.GA26533@pengutronix.de> References: <1322374332.2226.1.camel@phoenix> <20111127202212.44ebf4c4@endymion.delvare> <20111127194648.GA26533@pengutronix.de> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.20.1; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 27 Nov 2011 20:46:48 +0100, Wolfram Sang wrote: > > > > -module_init(gpiomux_init); > > > -module_exit(gpiomux_exit); > > > +module_platform_driver(gpiomux_driver); > > > > This one would be better as a separate patch, as it touches a different > > subdirectory, which I am responsible for. > > ... which has a patch pending[1], hint ;) > > [1] http://comments.gmane.org/gmane.linux.drivers.i2c/9432 Yes, that's one of the reasons why I think a separate patch would be more appropriate. It might be difficult to avoid patch collisions otherwise. -- Jean Delvare