From: Edward Donovan <edward.donovan@numble.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@elte.hu>, "Dave Airlie" <airlied@gmail.com>,
linux-kernel@vger.kernel.org, drivers_pci@kernel-bugs.osdl.org,
"Rogério Brito" <rbrito@ime.usp.br>,
"Maciej Rutecki" <maciej.rutecki@gmail.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: [PATCH] genirq: fix second 2.6.39 regression in irqfixup, irqpoll
Date: Sun, 27 Nov 2011 23:07:34 -0500 [thread overview]
Message-ID: <20111128040734.GA3590@Brahman> (raw)
In-Reply-To: <CA+55aFzh-ST1-Hu+Ny25X5DkEqktv3ZDFP2NDOWx6N+vFbTM8A@mail.gmail.com>
commit fa27271bc8d2("genirq: Fixup poll handling") introduced a
regression that broke irqfixup/irqpoll for some hardware
configurations. Amidst reorganizing 'try_one_irq', that patch removed
a test that checked for 'action->handler' returning IRQ_HANDLED,
before acting on the interrupt. Restoring this test back returns the
functionality lost since 2.6.39. In the current set of tests, after
'action' is set, it must precede '!action->next' to take effect.
With this and my previous patch to irq/spurious.c, c75d720fca8a, all
IRQ regressions that I have encountered are fixed.
Signed-off-by: Edward Donovan <edward.donovan@numble.net>
---
kernel/irq/spurious.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c
index b5f4742..dc813a9 100644
--- a/kernel/irq/spurious.c
+++ b/kernel/irq/spurious.c
@@ -84,7 +84,9 @@ static int try_one_irq(int irq, struct irq_desc *desc, bool force)
*/
action = desc->action;
if (!action || !(action->flags & IRQF_SHARED) ||
- (action->flags & __IRQF_TIMER) || !action->next)
+ (action->flags & __IRQF_TIMER) ||
+ (action->handler(irq, action->dev_id) == IRQ_HANDLED) ||
+ !action->next)
goto out;
/* Already running on another processor */
next prev parent reply other threads:[~2011-11-28 4:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-41132-5003@https.bugzilla.kernel.org/>
[not found] ` <201108160554.p7G5soeq002083@demeter2.kernel.org>
2011-11-22 8:10 ` [Bug 41132] [BISECTED][REGRESSION] Regression with the IRQ subsystem introduced in 2.6.39 (and present in the 3.x version) Rogério Brito
2011-11-27 20:22 ` Linus Torvalds
2011-11-28 3:46 ` Edward Donovan
2011-11-28 5:08 ` Rogério Brito
2011-11-28 4:07 ` Edward Donovan [this message]
2011-11-30 9:42 ` Thomas Gleixner
2011-11-20 1:54 [PATCH] genirq: fix second 2.6.39 regression in irqfixup, irqpoll Edward Donovan
2011-11-20 1:54 ` Edward Donovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111128040734.GA3590@Brahman \
--to=edward.donovan@numble.net \
--cc=airlied@gmail.com \
--cc=drivers_pci@kernel-bugs.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=mingo@elte.hu \
--cc=rbrito@ime.usp.br \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox