From: Borislav Petkov <bp@amd64.org>
To: Bob Tracy <rct@gherkin.frus.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BUG] 3.2-rcX regression: boot failure on AMD K6-III/450
Date: Mon, 28 Nov 2011 15:01:43 +0100 [thread overview]
Message-ID: <20111128140143.GA4522@x1.osrc.amd.com> (raw)
In-Reply-To: <20111126181724.GA1993@gherkin.frus.com>
Hi,
On Sat, Nov 26, 2011 at 12:17:24PM -0600, Bob Tracy wrote:
> Verified for 3.2-rc[1-3]. Subject system using LILO as bootloader.
> The following messages appear on the console:
>
> Loading linux-dev.
> BIOS data check successful
> Probing EDD (edd=off to disable)... ok
> <blank line>
> Decompressing Linux... Parsing ELF... done.
> Booting the kernel.
> <hang here -- no further output>
>
> The console output is normal and expected up to the point of the hang.
> Versions 3.1 and prior work fine. I had earlier thought the floppy
> regression Pavel reported applied to my case (and it may), but I don't
> seem to be getting that far in the boot process.
can you try the following patch:
--
From: Borislav Petkov <borislav.petkov@amd.com>
Date: Wed, 9 Nov 2011 18:08:40 +0100
Subject: [PATCH] x86, microcode, AMD: Restrict microcode reporting
bcb80e53877c ("x86, microcode, AMD: Add microcode revision to
/proc/cpuinfo") added support for dumping microcode patch level in
/proc/cpuinfo on AMD. Although we were very cautious and did rdmsr_safe
the microcode patch level MSR, this broke booting on Geode LX because
this CPU doesn't have that MSR and at the time we do the read, exception
tables which are used by rdmsr_safe are not yet initialized, leading to
the boot hang.
This is the simple fix which enables the microcode line in /proc/cpuinfo
for K8 and newer (it is not that interesting for older boxes anyway :-)).
Reported-and-bisected-and-tested-by: Daniel Drake <dsd@laptop.org>
Link: http://lkml.kernel.org/r/CAMLZHHTSuHZoPbm_YfB8G05JA+xKCE4+Jmj4NW8mnZUHogQSBA@mail.gmail.com
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
arch/x86/kernel/cpu/amd.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index c7e46cb..a72d183 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -474,7 +474,8 @@ static void __cpuinit early_init_amd(struct cpuinfo_x86 *c)
}
#endif
- rdmsr_safe(MSR_AMD64_PATCH_LEVEL, &c->microcode, &dummy);
+ if (c->x86 >= 0xf)
+ rdmsr_safe(MSR_AMD64_PATCH_LEVEL, &c->microcode, &dummy);
}
static void __cpuinit init_amd(struct cpuinfo_x86 *c)
--
1.7.8.rc0
Thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
next prev parent reply other threads:[~2011-11-28 14:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-26 18:17 [BUG] 3.2-rcX regression: boot failure on AMD K6-III/450 Bob Tracy
2011-11-28 14:01 ` Borislav Petkov [this message]
2011-11-28 14:47 ` Bob Tracy
2011-11-28 15:36 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111128140143.GA4522@x1.osrc.amd.com \
--to=bp@amd64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rct@gherkin.frus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox