From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753848Ab1K1OKM (ORCPT ); Mon, 28 Nov 2011 09:10:12 -0500 Received: from mga03.intel.com ([143.182.124.21]:41420 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753275Ab1K1OJI (ORCPT ); Mon, 28 Nov 2011 09:09:08 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.69,584,1315206000"; d="scan'208";a="79787557" Message-Id: <20111128140513.528601145@intel.com> User-Agent: quilt/0.48-1 Date: Mon, 28 Nov 2011 21:53:43 +0800 From: Wu Fengguang To: cc: Jan Kara , Chris Mason , Wu Fengguang cc: Peter Zijlstra CC: Christoph Hellwig cc: Andrew Morton Cc: LKML Subject: [PATCH 5/7] btrfs: fix dirtied pages accounting on sub-page writes References: <20111128135338.249672012@intel.com> Content-Disposition: inline; filename=btrfs-account-redirty Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When doing 1KB sequential writes to the same page, balance_dirty_pages_ratelimited_nr() should be called once instead of 4 times, the latter makes the dirtier tasks be throttled much too heavy. Fix it with proper de-accounting on clear_page_dirty_for_io(). CC: Chris Mason Signed-off-by: Wu Fengguang --- fs/btrfs/file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-next.orig/fs/btrfs/file.c 2011-11-17 20:13:47.000000000 +0800 +++ linux-next/fs/btrfs/file.c 2011-11-17 20:18:51.000000000 +0800 @@ -1136,7 +1136,8 @@ again: GFP_NOFS); } for (i = 0; i < num_pages; i++) { - clear_page_dirty_for_io(pages[i]); + if (clear_page_dirty_for_io(pages[i])) + account_page_redirty(pages[i]); set_page_extent_mapped(pages[i]); WARN_ON(!PageLocked(pages[i])); }