public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Donggeun Kim <dg77.kim@samsung.com>
Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com,
	broonie@opensource.wolfsonmicro.com, gregkh@suse.de,
	kyungmin.park@samsung.com, myungjoo.ham@samsung.com
Subject: Re: [PATCH 2/2] misc: add driver support for MAX8997 MUIC
Date: Mon, 28 Nov 2011 15:48:01 -0800	[thread overview]
Message-ID: <20111128154801.05f7c199.akpm@linux-foundation.org> (raw)
In-Reply-To: <1322125938-6944-3-git-send-email-dg77.kim@samsung.com>

On Thu, 24 Nov 2011 18:12:18 +0900
Donggeun Kim <dg77.kim@samsung.com> wrote:

> The MUIC function in MAX8997 device can be used as
> a USB port detector and switch.
> This patch supports the MUIC feature of MAX8997.
> 
> Signed-off-by: Donggeun Kim <dg77.kim@samsung.com>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>

Samuel, can you please merge this if/when it's ready?

>
> ...
>
> +static irqreturn_t max8997_muic_irq_handler(int irq, void *data)
> +{
> +	struct max8997_muic_info *info = data;
> +
> +	dev_dbg(info->dev, "irq:%d\n", irq);
> +	info->irq = irq;
> +
> +	schedule_work(&info->irq_work);
> +
> +	return IRQ_HANDLED;
> +}

The code does schedule_work() but I see no flush_work().  Is it
possible for the work to still be pending after device shutdown, or
even after rmmod?


  reply	other threads:[~2011-11-28 23:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-24  9:12 [PATCH 1/2] MFD: MAX8997: add platform data for MAX8997 MUIC driver Donggeun Kim
2011-11-24  9:12 ` [PATCH 2/2] misc: add driver support for MAX8997 MUIC Donggeun Kim
2011-11-28 23:48   ` Andrew Morton [this message]
2011-11-29  0:02     ` Kyungmin Park
2011-11-29  9:59     ` Samuel Ortiz
2011-12-12 17:08   ` Samuel Ortiz
2011-12-14 16:35     ` Arnd Bergmann
2011-12-12 17:06 ` [PATCH 1/2] MFD: MAX8997: add platform data for MAX8997 MUIC driver Samuel Ortiz
  -- strict thread matches above, loose matches on Subject: below --
2011-12-15  0:32 Re: [PATCH 2/2] misc: add driver support for MAX8997 MUIC MyungJoo Ham
2011-12-15 15:34 ` Arnd Bergmann
2011-12-15 17:25   ` Samuel Ortiz
2011-12-16  5:13 함명주
2011-12-16 13:58 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111128154801.05f7c199.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dg77.kim@samsung.com \
    --cc=gregkh@suse.de \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox