From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: David Ahern <dsahern@gmail.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
peterz@infradead.org, fweisbec@gmail.com
Subject: Re: [PATCH] perf tool: reset use_browser when compiled without NEWT
Date: Mon, 28 Nov 2011 15:09:45 -0200 [thread overview]
Message-ID: <20111128170945.GC12377@infradead.org> (raw)
In-Reply-To: <4ED3BDC6.2080104@gmail.com>
Em Mon, Nov 28, 2011 at 09:58:46AM -0700, David Ahern escreveu:
> Hi Arnaldo:
>
> didn't see this one in your queue or a response. Do you agree this is
> needed?
Well, I think we should provide a better explanation for this usecase,
i.e. the code as is will use --stdio in NO_NEWT=yes builds, but will
still offer --tui and if that is specified, will produce no output.
Perhaps it is best to either elide --tui in NO_NEWT builds or state that
the build doesn't support --tui more clearly.
Or are you seeing something else that you think needs fixing?
- Arnaldo
next prev parent reply other threads:[~2011-11-28 17:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 22:16 [PATCH] perf tool: reset use_browser when compiled without NEWT David Ahern
2011-11-28 16:58 ` David Ahern
2011-11-28 17:09 ` Arnaldo Carvalho de Melo [this message]
2011-11-28 17:16 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111128170945.GC12377@infradead.org \
--to=acme@infradead.org \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox