From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753677Ab1K1RqW (ORCPT ); Mon, 28 Nov 2011 12:46:22 -0500 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:27550 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753122Ab1K1RqV (ORCPT ); Mon, 28 Nov 2011 12:46:21 -0500 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 98.234.237.12 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19tIS8ARn+hsFQti6VzJ/Pp Date: Mon, 28 Nov 2011 09:46:16 -0800 From: Tony Lindgren To: Janusz Krzysztofik Cc: Paul Walmsley , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] ARM: OMAP1: Fix dpll1 reprogramming not actually allowed Message-ID: <20111128174616.GP31337@atomide.com> References: <1322364751-29980-1-git-send-email-jkrzyszt@tis.icnet.pl> <1322364751-29980-4-git-send-email-jkrzyszt@tis.icnet.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1322364751-29980-4-git-send-email-jkrzyszt@tis.icnet.pl> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Janusz Krzysztofik [111126 19:06]: > DPLL1 reprogramming to a different rate is actually blocked inside > omap1_select_table_rate(), resulting in the defalut rate of 60 MHz > always used instead of the one selected in .config. Fix it. > > Created against linux-3.2-rc2, tested on Amstrad Delta on top of > linux-omap/fixes. This too first requires something for boards to pass the supported rates. Tony > Signed-off-by: Janusz Krzysztofik > --- > arch/arm/mach-omap1/clock.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-omap1/clock.c b/arch/arm/mach-omap1/clock.c > index 3899176..962adbc 100644 > --- a/arch/arm/mach-omap1/clock.c > +++ b/arch/arm/mach-omap1/clock.c > @@ -200,10 +200,6 @@ int omap1_select_table_rate(struct clk *clk, unsigned long rate) > if (ptr->xtal != ref_rate) > continue; > > - /* DPLL1 cannot be reprogrammed without risking system crash */ > - if (likely(dpll1_rate != 0) && ptr->pll_rate != dpll1_rate) > - continue; > - > /* Can check only after xtal frequency check */ > if (ptr->rate <= rate) > break; > -- > 1.7.3.4 >