From: Ben Myers <bpm@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Simon Kirby <sim@hostway.ca>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: XFS read hangs in 3.1-rc10
Date: Mon, 28 Nov 2011 15:01:18 -0600 [thread overview]
Message-ID: <20111128210118.GT29840@sgi.com> (raw)
In-Reply-To: <20111128195505.GA3759@infradead.org>
Hey Christoph,
On Mon, Nov 28, 2011 at 02:55:05PM -0500, Christoph Hellwig wrote:
> On Mon, Nov 28, 2011 at 11:05:54AM -0800, Simon Kirby wrote:
> > On Sun, Nov 20, 2011 at 10:32:41AM -0500, Christoph Hellwig wrote:
> >
> > > On Wed, Nov 16, 2011 at 11:56:43AM -0800, Simon Kirby wrote:
> > > > Sorry for the delay in testing.
> > > >
> > > > Yes, everything looks fine even with the xfs_log_force line from your
> > > > patch commented out. So, the changes in xfs_reclaim_inode() are just the
> > > > set_bit(XBT_FORCE_FLUSH) and wake_up_process(), relative to 3.1.
> > >
> > > Dave pointed out that we can do better than the big hammer, and the
> > > patch below should fix your issue, too. Can you test it?
> >
> > Yes, seems to be fine. No hung task warnings, tested for ~5 days.
>
> Thanks a lot for the testing Simon.
>
> Ben, can you add a:
>
> Tested-by: Simon Kirby <sim@hostway.ca>
>
> to the patch when applying it?
Yep, I will add Simon's Tested-by:
Thanks Simon! ;)
-Ben
next prev parent reply other threads:[~2011-11-28 21:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 22:42 XFS read hangs in 3.1-rc10 Simon Kirby
2011-10-21 13:22 ` Christoph Hellwig
2011-10-21 20:28 ` Simon Kirby
2011-10-24 8:22 ` Christoph Hellwig
2011-10-25 20:07 ` Simon Kirby
2011-10-26 11:25 ` Christoph Hellwig
2011-11-04 21:03 ` Christoph Hellwig
2011-11-16 19:56 ` Simon Kirby
2011-11-20 15:32 ` Christoph Hellwig
2011-11-28 19:05 ` Simon Kirby
2011-11-28 19:55 ` Christoph Hellwig
2011-11-28 21:01 ` Ben Myers [this message]
2011-10-21 20:29 ` Markus Trippelsdorf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111128210118.GT29840@sgi.com \
--to=bpm@sgi.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sim@hostway.ca \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).