From: Tejun Heo <tj@kernel.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Pavel Emelyanov <xemul@parallels.com>,
Andi Kleen <andi@firstfloor.org>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [RFC] prctl: Add PR_ codes to restore vDSO and tune up mm_struct entires
Date: Mon, 28 Nov 2011 14:56:06 -0800 [thread overview]
Message-ID: <20111128225606.GD3858@google.com> (raw)
In-Reply-To: <20111124120051.GV1820@moon>
Hello, Cyrill.
On Thu, Nov 24, 2011 at 04:00:51PM +0400, Cyrill Gorcunov wrote:
> + case PR_SETUP_VDSO_AT:
> + if (arg3 | arg4 | arg5)
> + return -EINVAL;
> +
> + if (!capable(CAP_SYS_ADMIN))
> + return -EPERM;
> +
> +#ifdef ARCH_HAS_SETUP_ADDITIONAL_PAGES
> + error = arch_setup_additional_pages_at((void *)arg2);
> +#else
> + error = -ENOSYS;
> +#endif
> + break;
Hmmm... I'm not sure this is the best approach. vdso is supposed to
be able to be dependent on binprm too, so the proposed solution could
work but I'm not sure whether it's a good one. For now, can't we just
copy the vdso and unmap it at the orignal address?
Thanks.
--
tejun
next prev parent reply other threads:[~2011-11-28 22:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 12:00 [RFC] prctl: Add PR_ codes to restore vDSO and tune up mm_struct entires Cyrill Gorcunov
2011-11-28 22:56 ` Tejun Heo [this message]
2011-11-29 6:19 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111128225606.GD3858@google.com \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox