From: Andi Kleen <andi@firstfloor.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Youquan Song <youquan.song@intel.com>,
linux-kernel@vger.kernel.org, aarcange@redhat.com,
wli@holomorphy.com, david.woodhouse@intel.com,
allen.m.kay@intel.com, mtosatti@redhat.com, chrisw@redhat.com,
andi@firstfloor.org, chaohong.guo@intel.com,
Youquan Song <youquan.song@linux.intel.com>
Subject: Re: [PATCH 1/2] thp: Add compound tail page _mapcount when mapped
Date: Tue, 29 Nov 2011 01:19:27 +0100 [thread overview]
Message-ID: <20111129001927.GO24062@one.firstfloor.org> (raw)
In-Reply-To: <20111128161626.e4be400a.akpm@linux-foundation.org>
> > +++ b/arch/x86/mm/gup.c
> > @@ -201,6 +201,8 @@ static noinline int gup_huge_pud(pud_t pud, unsigned long addr,
> > do {
> > VM_BUG_ON(compound_head(page) != head);
> > pages[*nr] = page;
> > + if (PageTail(page))
> > + get_huge_page_tail(page);
> > (*nr)++;
> > page++;
> > refs++;
>
> Is the patch also applicable to 3.1.x?
I suspect it's broken since many kernels back, at least since THP
was introduced, maybe earlier.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2011-11-29 0:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 5:47 [PATCH 1/2] thp: Add compound tail page _mapcount when mapped Youquan Song
2011-11-25 5:47 ` [PATCH 2/2] thp: Set compound tail page _count to zero Youquan Song
2011-11-25 13:12 ` [PATCH 1/2] thp: Add compound tail page _mapcount when mapped Andrea Arcangeli
2011-11-29 0:16 ` Andrew Morton
2011-11-29 0:19 ` Andi Kleen [this message]
2011-11-29 0:58 ` Andrea Arcangeli
2011-11-29 18:00 ` Youquan Song
-- strict thread matches above, loose matches on Subject: below --
2011-11-26 3:23 Youquan Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111129001927.GO24062@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=allen.m.kay@intel.com \
--cc=chaohong.guo@intel.com \
--cc=chrisw@redhat.com \
--cc=david.woodhouse@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=wli@holomorphy.com \
--cc=youquan.song@intel.com \
--cc=youquan.song@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox