From: Will Deacon <will.deacon@arm.com>
To: David Miller <davem@davemloft.net>
Cc: "eric.dumazet@gmail.com" <eric.dumazet@gmail.com>,
"mmaruseac@ixiacom.com" <mmaruseac@ixiacom.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: NULL pointer dereference in mainline and next
Date: Tue, 29 Nov 2011 10:04:42 +0000 [thread overview]
Message-ID: <20111129100442.GB26310@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <20111128.170840.1847881572380941723.davem@davemloft.net>
On Mon, Nov 28, 2011 at 10:08:40PM +0000, David Miller wrote:
> From: Will Deacon <will.deacon@arm.com>
> Date: Mon, 28 Nov 2011 14:35:58 +0000
>
> > On Mon, Nov 28, 2011 at 02:33:24PM +0000, Eric Dumazet wrote:
> >> Le lundi 28 novembre 2011 à 14:18 +0000, Will Deacon a écrit :
> >> > Hello,
> >> >
> >> > Commit f04565dd ("dev: use name hash for dev_seq_ops") requires a struct
> >> > dev_iter_state to be allocated for the seq_file->private member, as that is
> >> > used to implement the name hash.
> >> >
> >> > Unfortunately, the dev_mcast code wasn't updated and so only allocates space
> >> > for a seq_net_private, leading to the following NULL dereference (removed
> >> > static inline annotations to get sane backtrace):
> >
> > [...]
> >
> >> Anton Blanchard already provided a fix for this problem.
> >>
> >> http://patchwork.ozlabs.org/patch/127931/
> >
> > Ok, great - as long as it gets fixed!
>
> Please in the future report networking bugs to netdev@vger.kernel.org as that
> will reach the largest number of networking developers.
Sure, I just stumbled across this testing some ARM stuff, but I'll bear that
in mind in future.
Cheers,
Will
prev parent reply other threads:[~2011-11-29 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 14:18 NULL pointer dereference in mainline and next Will Deacon
2011-11-28 14:33 ` Eric Dumazet
2011-11-28 14:35 ` Will Deacon
2011-11-28 22:08 ` David Miller
2011-11-29 10:04 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111129100442.GB26310@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmaruseac@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox