From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: Liam Girdwood <lrg@ti.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
Mike Frysinger <vapier@gentoo.org>,
Daniel Mack <zonque@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
qi.wang@intel.com, yong.y.wang@intel.com, joel.clark@intel.com,
kok.howg.ewe@intel.com
Subject: Re: [PATCH v4] sound/soc/codecs: add LAPIS Semiconductor ML26124
Date: Tue, 29 Nov 2011 12:50:29 +0000 [thread overview]
Message-ID: <20111129125029.GN2851@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1322569736-16782-1-git-send-email-tomoya.rohm@gmail.com>
On Tue, Nov 29, 2011 at 09:28:56PM +0900, Tomoya MORINAGA wrote:
> ML26124-01HB/ML26124-02GD is 16bit monaural audio CODEC which has high
> resistance to voltage noise. On chip regulator realizes power supply rejection
> ratio be over 90dB so more than 50dB is improved than ever. ML26124-01HB/
Given the questions you just asked myself and Lars-Peter it seems fairly
clear that the review comments from the previous version so I'm not
going to review this, please resend once the review comments have been
addressed. Lars-Peter concern seemed especially serious, I'd expect
large sections of the audio functionality to not work without being
connected to the DAPM map.
In general if resubmitting code that has outstanding review issues you
should highlight the known issues and explain why you are resending;
usually if there's an active discussion in progress it's better to wait
for that to die down.
next prev parent reply other threads:[~2011-11-29 12:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 12:28 [PATCH v4] sound/soc/codecs: add LAPIS Semiconductor ML26124 Tomoya MORINAGA
2011-11-29 12:50 ` Mark Brown [this message]
2011-11-30 5:48 ` Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111129125029.GN2851@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=perex@perex.cz \
--cc=qi.wang@intel.com \
--cc=tiwai@suse.de \
--cc=tomoya.rohm@gmail.com \
--cc=vapier@gentoo.org \
--cc=yong.y.wang@intel.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox