From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753646Ab1K3GFp (ORCPT <rfc822;w@1wt.eu>);
	Wed, 30 Nov 2011 01:05:45 -0500
Received: from mail-bw0-f46.google.com ([209.85.214.46]:36928 "EHLO
	mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752373Ab1K3GFn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 30 Nov 2011 01:05:43 -0500
Date: Wed, 30 Nov 2011 10:05:37 +0400
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
        Tejun Heo <tj@kernel.org>, Andrew Vagin <avagin@openvz.org>,
        Serge Hallyn <serge.hallyn@canonical.com>,
        Pavel Emelyanov <xemul@parallels.com>,
        Vasiliy Kulikov <segoon@openwall.com>
Subject: Re: [rfc 2/3] fs, proc: Introduce the Children: line in
 /proc/<pid>/status
Message-ID: <20111130060537.GK1775@moon>
References: <20111129191252.769160532@openvz.org>
 <20111129191638.835932727@openvz.org>
 <20111130140009.1ccd5af0.kamezawa.hiroyu@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20111130140009.1ccd5af0.kamezawa.hiroyu@jp.fujitsu.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 30, 2011 at 02:00:09PM +0900, KAMEZAWA Hiroyuki wrote:
> On Tue, 29 Nov 2011 23:12:54 +0400
> Cyrill Gorcunov <gorcunov@openvz.org> wrote:
> 
> > From: Pavel Emelyanov <xemul@parallels.com>
> > 
> > There is no easy way to make a reverse parent->children chain
> > from the task status, in turn children->parent provided with "PPid"
> > field.
> > 
> > So instead of walking over all pids in system to figure out what
> > children the task have -- we add explicit "Children" member to
> > /proc/<pid>/status since kernel already knows this kind of information
> > but it was not yet exported.
> > 
> > Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
> > Acked-by: Serge Hallyn <serge.hallyn@canonical.com>
> > Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> 
> I may be too pessimistic but what amount of overhead will this add to
> ps -elf/ top ? Assuming an environment 'ps -elf' is called once per a sec,
> if there are 2000 processes, task_list lock is taken 2000 times by this patch.
> 

Hi Kame, good point! Yes, it introduces latency on high loaded systems.
I must admit I tested this patch on a regular system, where not that much
processes were launched but technically I think more correct would be to
switch to children file. I'll tune up the patch. Thanks!

> Isn't it better to add /proc/<pid>/children file or dir (as task)?
> 
> Thanks,
> -Kame
>