From: Al Viro <viro@ZenIV.linux.org.uk>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] trimming includes from linux/security.h
Date: Wed, 30 Nov 2011 07:47:45 +0000 [thread overview]
Message-ID: <20111130074745.GV2203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <201111300709.pAU79PAs010669@www262.sakura.ne.jp>
On Wed, Nov 30, 2011 at 04:09:25PM +0900, Tetsuo Handa wrote:
> Al Viro wrote:
> > linux/security.h pulls a lot of garbage; most of it can be avoided
> > by several more struct ....; added in there,
>
> Does it make sense to create a header file that contains only "struct ....;"
> lines? A lot of "struct ....;" lines are used for avoiding compiler warning.
> This results in LXR (linux cross reference) showing like
>
> Defined as a struct type in:
>
> * security/selinux/include/avc.h, line 35
Er... Then LXR sucks. It's trivial to distinguish those from actual
definition; talks to LXR folks and let them fix their code...
struct <tag> ;
vs
struct <tag> {
is not that hard to handle, even if you bother with __attribute__ in weird
places like that. They need to distinguish those from
struct <tag> <ident>
etc., after all, so they do some amount of lookahead...
next prev parent reply other threads:[~2011-11-30 7:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 6:50 [RFC][PATCH] trimming includes from linux/security.h Al Viro
2011-11-30 7:09 ` Tetsuo Handa
2011-11-30 7:47 ` Al Viro [this message]
2011-11-30 20:41 ` Paul Gortmaker
2011-11-30 22:29 ` Al Viro
2011-12-01 0:39 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111130074745.GV2203@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).