From: "Serge E. Hallyn" <serge@hallyn.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Doug Ledford <dledford@redhat.com>, Jiri Slaby <jslaby@suse.cz>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Davidlohr Bueso <dave@gnu.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] ipc/mqueue: lock() => unlock() typo
Date: Wed, 30 Nov 2011 16:36:07 +0000 [thread overview]
Message-ID: <20111130163607.GA32365@hallyn.com> (raw)
In-Reply-To: <20111130135604.GA2803@elgon.mountain>
Quoting Dan Carpenter (dan.carpenter@oracle.com):
> There was a double lock typo introduced in b085f4bd6b21 "user namespace:
> make signal.c respect user namespaces"
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Jinkeys!
Acked-by: Serge Hallyn <serge@hallyn.com>
thanks very much, Dan.
-serge
> ---
> I think this patch is only needed in the -mm tree.
>
> diff --git a/ipc/mqueue.c b/ipc/mqueue.c
> index 691cfee..c246c83 100644
> --- a/ipc/mqueue.c
> +++ b/ipc/mqueue.c
> @@ -558,7 +558,7 @@ static void __do_notify(struct mqueue_inode_info *info)
> ns_of_pid(info->notify_owner));
> sig_i.si_uid = user_ns_map_uid(info->user->user_ns,
> current_cred(), current_uid());
> - rcu_read_lock();
> + rcu_read_unlock();
>
> kill_pid_info(info->notify.sigev_signo,
> &sig_i, info->notify_owner);
prev parent reply other threads:[~2011-11-30 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 13:56 [patch -next] ipc/mqueue: lock() => unlock() typo Dan Carpenter
2011-11-30 16:36 ` Serge E. Hallyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111130163607.GA32365@hallyn.com \
--to=serge@hallyn.com \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=dave@gnu.org \
--cc=dledford@redhat.com \
--cc=jslaby@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox