* [patch -next] ipc/mqueue: lock() => unlock() typo
@ 2011-11-30 13:56 Dan Carpenter
2011-11-30 16:36 ` Serge E. Hallyn
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-11-30 13:56 UTC (permalink / raw)
To: Andrew Morton, Serge E. Hallyn
Cc: Doug Ledford, Jiri Slaby, Stephen Rothwell, Davidlohr Bueso,
linux-kernel, kernel-janitors
There was a double lock typo introduced in b085f4bd6b21 "user namespace:
make signal.c respect user namespaces"
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I think this patch is only needed in the -mm tree.
diff --git a/ipc/mqueue.c b/ipc/mqueue.c
index 691cfee..c246c83 100644
--- a/ipc/mqueue.c
+++ b/ipc/mqueue.c
@@ -558,7 +558,7 @@ static void __do_notify(struct mqueue_inode_info *info)
ns_of_pid(info->notify_owner));
sig_i.si_uid = user_ns_map_uid(info->user->user_ns,
current_cred(), current_uid());
- rcu_read_lock();
+ rcu_read_unlock();
kill_pid_info(info->notify.sigev_signo,
&sig_i, info->notify_owner);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch -next] ipc/mqueue: lock() => unlock() typo
2011-11-30 13:56 [patch -next] ipc/mqueue: lock() => unlock() typo Dan Carpenter
@ 2011-11-30 16:36 ` Serge E. Hallyn
0 siblings, 0 replies; 2+ messages in thread
From: Serge E. Hallyn @ 2011-11-30 16:36 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andrew Morton, Doug Ledford, Jiri Slaby, Stephen Rothwell,
Davidlohr Bueso, linux-kernel, kernel-janitors
Quoting Dan Carpenter (dan.carpenter@oracle.com):
> There was a double lock typo introduced in b085f4bd6b21 "user namespace:
> make signal.c respect user namespaces"
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Jinkeys!
Acked-by: Serge Hallyn <serge@hallyn.com>
thanks very much, Dan.
-serge
> ---
> I think this patch is only needed in the -mm tree.
>
> diff --git a/ipc/mqueue.c b/ipc/mqueue.c
> index 691cfee..c246c83 100644
> --- a/ipc/mqueue.c
> +++ b/ipc/mqueue.c
> @@ -558,7 +558,7 @@ static void __do_notify(struct mqueue_inode_info *info)
> ns_of_pid(info->notify_owner));
> sig_i.si_uid = user_ns_map_uid(info->user->user_ns,
> current_cred(), current_uid());
> - rcu_read_lock();
> + rcu_read_unlock();
>
> kill_pid_info(info->notify.sigev_signo,
> &sig_i, info->notify_owner);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-30 16:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-30 13:56 [patch -next] ipc/mqueue: lock() => unlock() typo Dan Carpenter
2011-11-30 16:36 ` Serge E. Hallyn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox