public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org,
	linux-pm@vger.kernel.org, tj@kernel.org, john@calva.com,
	trond.myklebust@netapp.com, marek.belisko@gmail.com,
	awilliam@redhat.com
Subject: Re: [PATCH v4 0/2] nfs/sunrpc: allow freezing of tasks with NFS calls in flight
Date: Wed, 30 Nov 2011 20:43:13 +0100	[thread overview]
Message-ID: <201111302043.13844.rjw@sisk.pl> (raw)
In-Reply-To: <1322570215-8570-1-git-send-email-jlayton@redhat.com>

On Tuesday, November 29, 2011, Jeff Layton wrote:
> This patchset is the fourth attempt at fixing the issues with suspending
> a machine that has an active NFS mount.
> 
> The bug reported against Fedora is here:
> 
>     https://bugzilla.redhat.com/show_bug.cgi?id=717735
> 
> The main difference from v3 is that I've fixed a stupid set of errors in
> freezable_schedule_timeout_killable. The if condition was reversed from
> what it should have been, and the code did not call freezer_count()
> again when it was going to return early.
> 
> Tejun has mentioned that the extra try_to_freeze() calls are unnecessary
> on top of the pm-freezer changes, but this set should work on as
> expected on top of 3.2-ish kernels. In the meantime, I'll look over the
> pm-freezer changes and see whether I need to make changes in this set
> for 3.3.
> 
> Jeff Layton (2):
>   sunrpc: make rpc_wait_bit_killable handle freeze events
>   nfs: make TASK_KILLABLE sleeps attempt to freeze

Both patches applied to linux-pm/linux-next.  I'll move them to
linux-pm/pm-freezer in a couple of days if there are no problems with
them.

Thanks,
Rafael


>  fs/nfs/inode.c          |    3 ++-
>  fs/nfs/nfs3proc.c       |    3 ++-
>  fs/nfs/nfs4proc.c       |    5 +++--
>  fs/nfs/proc.c           |    3 ++-
>  include/linux/freezer.h |   42 ++++++++++++++++++++++++++++++++++++++++++
>  net/sunrpc/sched.c      |    3 ++-
>  6 files changed, 53 insertions(+), 6 deletions(-)
> 
> 


  parent reply	other threads:[~2011-11-30 19:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29 12:36 [PATCH v4 0/2] nfs/sunrpc: allow freezing of tasks with NFS calls in flight Jeff Layton
2011-11-29 12:36 ` [PATCH v4 1/2] sunrpc: make rpc_wait_bit_killable handle freeze events Jeff Layton
2011-11-29 12:36 ` [PATCH v4 2/2] nfs: make TASK_KILLABLE sleeps attempt to freeze Jeff Layton
2011-11-30 19:43 ` Rafael J. Wysocki [this message]
2011-12-01 18:49   ` [PATCH v4 0/2] nfs/sunrpc: allow freezing of tasks with NFS calls in flight Tejun Heo
2011-12-01 19:32     ` Adam Williamson
2011-12-01 21:13       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201111302043.13844.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=awilliam@redhat.com \
    --cc=jlayton@redhat.com \
    --cc=john@calva.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=marek.belisko@gmail.com \
    --cc=tj@kernel.org \
    --cc=trond.myklebust@netapp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox