* [PATCH] firmware: google: fix gsmi.c build warning
@ 2011-11-30 23:37 Maxin B. John
2011-11-30 23:56 ` Mike Waychison
0 siblings, 1 reply; 7+ messages in thread
From: Maxin B. John @ 2011-11-30 23:37 UTC (permalink / raw)
To: linux-kernel; +Cc: gregkh, paul.gortmaker, mikew, dlaurie, adurbin
Use min_t() macro instead of min() to fix a build warning:
CC drivers/firmware/google/gsmi.o
drivers/firmware/google/gsmi.c: In function ‘gsmi_get_variable’:
drivers/firmware/google/gsmi.c:348: warning: comparison of distinct
pointer types lacks a cast
Signed-off-by: Maxin B. John <maxin.john@gmail.com>
---
diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c
index c4e7c59..91ddf0f 100644
--- a/drivers/firmware/google/gsmi.c
+++ b/drivers/firmware/google/gsmi.c
@@ -345,7 +345,8 @@ static efi_status_t gsmi_get_variable(efi_char16_t *name,
memcpy(¶m, gsmi_dev.param_buf->start, sizeof(param));
/* The size reported is the min of all of our buffers */
- *data_size = min(*data_size, gsmi_dev.data_buf->length);
+ *data_size = min_t(unsigned long, *data_size,
+ gsmi_dev.data_buf->length);
*data_size = min_t(unsigned long, *data_size, param.data_len);
/* Copy data back to return buffer. */
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] firmware: google: fix gsmi.c build warning
2011-11-30 23:37 [PATCH] firmware: google: fix gsmi.c build warning Maxin B. John
@ 2011-11-30 23:56 ` Mike Waychison
2011-12-01 3:21 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Mike Waychison @ 2011-11-30 23:56 UTC (permalink / raw)
To: Maxin B. John; +Cc: linux-kernel, gregkh, paul.gortmaker, dlaurie, adurbin
On Wed, Nov 30, 2011 at 3:37 PM, Maxin B. John <maxin.john@gmail.com> wrote:
> Use min_t() macro instead of min() to fix a build warning:
>
Looks good. Greg, could you please pull this into your drivers tree?
> CC drivers/firmware/google/gsmi.o
> drivers/firmware/google/gsmi.c: In function ‘gsmi_get_variable’:
> drivers/firmware/google/gsmi.c:348: warning: comparison of distinct
> pointer types lacks a cast
>
> Signed-off-by: Maxin B. John <maxin.john@gmail.com>
> ---
> diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c
> index c4e7c59..91ddf0f 100644
> --- a/drivers/firmware/google/gsmi.c
> +++ b/drivers/firmware/google/gsmi.c
> @@ -345,7 +345,8 @@ static efi_status_t gsmi_get_variable(efi_char16_t *name,
> memcpy(¶m, gsmi_dev.param_buf->start, sizeof(param));
>
> /* The size reported is the min of all of our buffers */
> - *data_size = min(*data_size, gsmi_dev.data_buf->length);
> + *data_size = min_t(unsigned long, *data_size,
> + gsmi_dev.data_buf->length);
> *data_size = min_t(unsigned long, *data_size, param.data_len);
>
> /* Copy data back to return buffer. */
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] firmware: google: fix gsmi.c build warning
2011-11-30 23:56 ` Mike Waychison
@ 2011-12-01 3:21 ` Greg KH
2011-12-01 6:07 ` Mike Waychison
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2011-12-01 3:21 UTC (permalink / raw)
To: Mike Waychison
Cc: Maxin B. John, linux-kernel, paul.gortmaker, dlaurie, adurbin
On Wed, Nov 30, 2011 at 03:56:25PM -0800, Mike Waychison wrote:
> On Wed, Nov 30, 2011 at 3:37 PM, Maxin B. John <maxin.john@gmail.com> wrote:
> > Use min_t() macro instead of min() to fix a build warning:
> >
>
> Looks good. Greg, could you please pull this into your drivers tree?
Yes I will if you ack it :)
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] firmware: google: fix gsmi.c build warning
2011-12-01 3:21 ` Greg KH
@ 2011-12-01 6:07 ` Mike Waychison
2011-12-01 14:29 ` Maxin B John
0 siblings, 1 reply; 7+ messages in thread
From: Mike Waychison @ 2011-12-01 6:07 UTC (permalink / raw)
To: Greg KH; +Cc: Maxin B. John, linux-kernel, paul.gortmaker, dlaurie, adurbin
On Wed, Nov 30, 2011 at 7:21 PM, Greg KH <gregkh@suse.de> wrote:
> On Wed, Nov 30, 2011 at 03:56:25PM -0800, Mike Waychison wrote:
>> On Wed, Nov 30, 2011 at 3:37 PM, Maxin B. John <maxin.john@gmail.com> wrote:
>> > Use min_t() macro instead of min() to fix a build warning:
>> >
>>
>> Looks good. Greg, could you please pull this into your drivers tree?
>
> Yes I will if you ack it :)
Acked-By: Mike Waychison <mikew@google.com>
>
> greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] firmware: google: fix gsmi.c build warning
2011-12-01 6:07 ` Mike Waychison
@ 2011-12-01 14:29 ` Maxin B John
2011-12-07 11:55 ` Maxin B John
0 siblings, 1 reply; 7+ messages in thread
From: Maxin B John @ 2011-12-01 14:29 UTC (permalink / raw)
To: Mike Waychison; +Cc: Greg KH, linux-kernel, paul.gortmaker, dlaurie, adurbin
On Thu, Dec 1, 2011 at 8:07 AM, Mike Waychison <mikew@google.com> wrote:
> On Wed, Nov 30, 2011 at 7:21 PM, Greg KH <gregkh@suse.de> wrote:
>> On Wed, Nov 30, 2011 at 03:56:25PM -0800, Mike Waychison wrote:
>>> On Wed, Nov 30, 2011 at 3:37 PM, Maxin B. John <maxin.john@gmail.com> wrote:
>>> > Use min_t() macro instead of min() to fix a build warning:
>>> >
>>>
>>> Looks good. Greg, could you please pull this into your drivers tree?
>>
>> Yes I will if you ack it :)
>
> Acked-By: Mike Waychison <mikew@google.com>
Thanks !
>>
>> greg k-h
Warm Regards,
Maxin B. John
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] firmware: google: fix gsmi.c build warning
2011-12-01 14:29 ` Maxin B John
@ 2011-12-07 11:55 ` Maxin B John
2011-12-07 17:16 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Maxin B John @ 2011-12-07 11:55 UTC (permalink / raw)
To: Greg KH; +Cc: Mike Waychison, linux-kernel, paul.gortmaker, dlaurie, adurbin
On Thu, Dec 1, 2011 at 4:29 PM, Maxin B John <maxin.john@gmail.com> wrote:
> On Thu, Dec 1, 2011 at 8:07 AM, Mike Waychison <mikew@google.com> wrote:
>> On Wed, Nov 30, 2011 at 7:21 PM, Greg KH <gregkh@suse.de> wrote:
>>> On Wed, Nov 30, 2011 at 03:56:25PM -0800, Mike Waychison wrote:
>>>> On Wed, Nov 30, 2011 at 3:37 PM, Maxin B. John <maxin.john@gmail.com> wrote:
>>>> > Use min_t() macro instead of min() to fix a build warning:
>>>> >
>>>>
>>>> Looks good. Greg, could you please pull this into your drivers tree?
>>>
>>> Yes I will if you ack it :)
>>
>> Acked-By: Mike Waychison <mikew@google.com>
Greg, Ping ..
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] firmware: google: fix gsmi.c build warning
2011-12-07 11:55 ` Maxin B John
@ 2011-12-07 17:16 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2011-12-07 17:16 UTC (permalink / raw)
To: Maxin B John
Cc: Mike Waychison, linux-kernel, paul.gortmaker, dlaurie, adurbin
On Wed, Dec 07, 2011 at 01:55:30PM +0200, Maxin B John wrote:
> On Thu, Dec 1, 2011 at 4:29 PM, Maxin B John <maxin.john@gmail.com> wrote:
> > On Thu, Dec 1, 2011 at 8:07 AM, Mike Waychison <mikew@google.com> wrote:
> >> On Wed, Nov 30, 2011 at 7:21 PM, Greg KH <gregkh@suse.de> wrote:
> >>> On Wed, Nov 30, 2011 at 03:56:25PM -0800, Mike Waychison wrote:
> >>>> On Wed, Nov 30, 2011 at 3:37 PM, Maxin B. John <maxin.john@gmail.com> wrote:
> >>>> > Use min_t() macro instead of min() to fix a build warning:
> >>>> >
> >>>>
> >>>> Looks good. Greg, could you please pull this into your drivers tree?
> >>>
> >>> Yes I will if you ack it :)
> >>
> >> Acked-By: Mike Waychison <mikew@google.com>
>
> Greg, Ping ..
It's in my queue, patience please.
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-12-07 17:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-30 23:37 [PATCH] firmware: google: fix gsmi.c build warning Maxin B. John
2011-11-30 23:56 ` Mike Waychison
2011-12-01 3:21 ` Greg KH
2011-12-01 6:07 ` Mike Waychison
2011-12-01 14:29 ` Maxin B John
2011-12-07 11:55 ` Maxin B John
2011-12-07 17:16 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox