Re: [PATCH 1/4] staging: vt6656: channel.c: Remove dead code

[Dan Carpenter <dan.carpenter@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]

On Thu, Dec 01, 2011 at 12:22:49AM +0000, Marcos Paulo de Souza wrote:
> This patch remove some unneeded code. Some comments, for loop doing
> nothing, debug messages and unneeded variables was removed.
> 

This rewrites some stuff, it's not just deleting stuff...  Yes,
you've rewritten it in a better way, but you should mention that in
the changelog.  Maybe break it up into smaller patches or something?

> @@ -463,51 +444,23 @@ void CHvInitChannelTable(void *pDeviceHandler)
>  
>      if ((pDevice->dwDiagRefCount != 0) ||
>          (pDevice->b11hEable == TRUE)) {
> -        if (bMultiBand == TRUE) {
> -		for (ii = 0; ii < CB_MAX_CHANNEL; ii++) {
> +	if (bMultiBand == TRUE)
                                ^
Don't delete the '{' from here.  Multi-line indents get {} braces
even though it's not needed for semantic reasons.

I told you that yesterday.  :/

> +		for (ii = 0; ii < CB_MAX_CHANNEL; ii++)
>  			sChannelTbl[ii+1].bValid = TRUE;

regards,
dan carpenter


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]