From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marcos Paulo de Souza <marcos.mage@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@suse.de>,
Forest Bond <forest@alittletooquiet.net>
Subject: Re: [PATCH 3/4] staging: vt6656: datarate.c: Remove unneeded comments
Date: Thu, 1 Dec 2011 18:10:26 +0300 [thread overview]
Message-ID: <20111201151026.GX3195@mwanda> (raw)
In-Reply-To: <1322699517-19721-1-git-send-email-marcos.mage@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On Thu, Dec 01, 2011 at 12:31:57AM +0000, Marcos Paulo de Souza wrote:
> - // clear statistic counter for auto_rate
> - for (ii = 0; ii <= MAX_RATE; ii++) {
> - psNodeDBTable->uTxOk[ii] = 0;
> - psNodeDBTable->uTxFail[ii] = 0;
> - }
> + /* clear statistic counter for auto_rate */
> + for (ii = 0; ii <= MAX_RATE; ii++)
> + psNodeDBTable->uTxOk[ii] = psNodeDBTable->uTxFail[ii] = 0;
> }
>
Don't do that... Better to have the assignments on separate lines.
If you wanted, you could use memset and get rid of the loop.
void s_vResetCounter(PKnownNodeDB psNodeDBTable)
{
memset(psNodeDBTable->uTxOk, 0, sizeof(psNodeDBTable->uTxOk));
memset(psNodeDBTable->uTxFail, 0, sizeof(psNodeDBTable->uTxFail));
}
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2011-12-01 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 0:31 [PATCH 3/4] staging: vt6656: datarate.c: Remove unneeded comments Marcos Paulo de Souza
2011-12-01 15:10 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111201151026.GX3195@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcos.mage@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox