From: Andrew Morton <akpm@linux-foundation.org>
To: Petr Holasek <pholasek@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, Anton Arapov <anton@redhat.com>
Subject: Re: NUMA x86: add constraints check for nid parameters
Date: Thu, 1 Dec 2011 15:28:51 -0800 [thread overview]
Message-ID: <20111201152851.7e39f034.akpm@linux-foundation.org> (raw)
In-Reply-To: <20111201231441.GA3293@stainedmachine.redhat.com>
On Fri, 2 Dec 2011 00:14:42 +0100
Petr Holasek <pholasek@redhat.com> wrote:
> On Thu, 01 Dec 2011, Andrew Morton wrote:
>
> > Date: Thu, 1 Dec 2011 13:34:51 -0800
> > From: Andrew Morton <akpm@linux-foundation.org>
> > To: Petr Holasek <pholasek@redhat.com>
> > Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
> > "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org, Anton
> > Arapov <anton@redhat.com>
> > Subject: Re: [PATCH RESEND] NUMA x86: add constraints check for nid
> > parameters
> >
> > On Thu, 1 Dec 2011 12:45:07 +0100
> > Petr Holasek <pholasek@redhat.com> wrote:
> >
> > > This patch adds constraints checks into __node_distance() and
> > > numa_set_distance() functions. If from or to parameters are
> > > lower than zero, it results into oops now.
> >
> > Passing negative numbers into __node_distance() sounds like a bug in
> > the caller, and this patch will remove our means of detecting that bug.
>
> That's true, but upper boundary is checked now, so why not to check lower?
Because it adds more code to the kernel and can hide bugs?
> Seems inconsistent to me - from this point of view even don't check anything
> would be better for detecting bug in the caller.
>
> >
> > Perhaps we need to be told more about this patch. Is the bug
> > user-triggerable? If so, how? How was this fault triggered?
> > Etcetera.
> >
>
> AFAIK, neither __node_distance() nor numa_set_distance() aren't in any
> path from user-space inputs. Their paramaters are based on ACPI tables
> provided by HW vendors.
That didn't answer my questions. Have you observed any problems in
this code? If so, please fully describe them. Or was it purely from
code inspection?
If what we're doing here is to be defensive against buggy BIOS tables
(a good idea) then we should validate the BIOS table values as close as
possible to the point where they were read frmo the BIOS. And we should
(probably) emit a warning if a bad table entry is detected, rather than
silently fixing it up.
next prev parent reply other threads:[~2011-12-01 23:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 11:45 [PATCH RESEND] NUMA x86: add constraints check for nid parameters Petr Holasek
2011-12-01 21:34 ` Andrew Morton
2011-12-01 23:14 ` Petr Holasek
2011-12-01 23:28 ` Andrew Morton [this message]
2011-12-02 10:55 ` Petr Holasek
2011-12-06 20:45 ` David Rientjes
2011-12-07 19:40 ` Petr Holasek
2011-12-07 19:43 ` [PATCH v2] " Petr Holasek
2011-12-07 21:46 ` David Rientjes
2011-12-08 12:16 ` [PATCH v3] " Petr Holasek
2011-12-08 21:09 ` David Rientjes
2011-12-09 7:10 ` Ingo Molnar
2011-12-09 10:44 ` David Rientjes
2011-12-09 20:08 ` [tip:x86/mm] x86/numa: Add " tip-bot for Petr Holasek
2011-12-08 18:58 ` [PATCH v2] NUMA x86: add " Andi Kleen
2011-12-08 21:12 ` David Rientjes
2011-12-09 7:11 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111201152851.7e39f034.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=anton@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pholasek@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox