From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755211Ab1LAW2Q (ORCPT ); Thu, 1 Dec 2011 17:28:16 -0500 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:44491 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754892Ab1LAW2P (ORCPT ); Thu, 1 Dec 2011 17:28:15 -0500 Date: Thu, 1 Dec 2011 17:28:03 -0500 From: Christoph Hellwig To: Greg KH Cc: Christoph Hellwig , Mathieu Desnoyers , devel@driverdev.osuosl.org, lttng-dev@lists.lttng.org, Linus Torvalds , Christoph Lameter , Tejun Heo , David Howells , David McCullough , D Jeff Dionne , Greg Ungerer , Paul Mundt , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/11] mm: export vmalloc_sync_all symbol to GPL modules Message-ID: <20111201222803.GA10853@infradead.org> References: <1322775683-8741-1-git-send-email-mathieu.desnoyers@efficios.com> <1322775683-8741-2-git-send-email-mathieu.desnoyers@efficios.com> <20111201215700.GA16782@infradead.org> <20111201221337.GB3365@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111201221337.GB3365@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 01, 2011 at 02:13:37PM -0800, Greg KH wrote: > On Thu, Dec 01, 2011 at 04:57:00PM -0500, Christoph Hellwig wrote: > > On Thu, Dec 01, 2011 at 04:41:13PM -0500, Mathieu Desnoyers wrote: > > > LTTng needs this symbol exported. It calls it to ensure its tracing > > > buffers and allocated data structures never trigger a page fault. This > > > is required to handle page fault handler tracing and NMI tracing > > > gracefully. > > > > We: > > > > a) don't export symbols unless they have an intree-user > > lttng is now in-tree in the drivers/staging/ area. See linux-next for > details if you are curious. Eww - merging stuff without discussion on lkml is more than evil. Either way, it was guaranteed that drivers/staging is considered out of tree for core code. I'm defintively dead set against exporting anything for staging and opening that slippery slope.